Export to GitHub

google-web-toolkit - issue #8578

Make xsiframe the default linker. Deprecate the std and xs linkers.


Posted on Feb 16, 2014 by Swift Rhino

Given the current (and future) state of DevMode vs. SuperDevMode, we should make xsiframe the default linker as we now expect everyone to use it (unless they need another specific linker).

We should probably also deprecate the "std" (iframe) and "xs" linkers, at least annotating them with @Deprecated for those who extended them, possibly emitting a warning at compile-time (that could be disabled with a configuration property).

Comment #1

Posted on Feb 16, 2014 by Swift Rhino

https://gwt-review.googlesource.com/6424 and https://gwt-review.googlesource.com/6425

Comment #2

Posted on Feb 25, 2014 by Massive Cat

(No comment was entered for this change.)

Comment #3

Posted on Feb 27, 2014 by Swift Rhino

The first patch making xsiframe the default linker has been merged, so marking as FixedNotReleased.

Comment #4

Posted on Mar 7, 2014 by Swift Rhino

Suggested text for the release notes:

The xsiframe linker is now the default linker. If you (your build, test automation, etc.) depend on the iframe linker (e.g. *.cache.html being loaded into iframes), you can switch back by adding to your gwt.xml. Note however that the iframe and xs linkers are no longer maintained and thus considered deprecated.

Comment #5

Posted on Mar 12, 2014 by Happy Elephant

I'm thinking of changing the default linker again, from CrossSiteIFrameLinker to DirectInstallLinker, which is a trivial subclass that causes each JavaScript fragment to be loaded as a plain js file.

CrossSiteIFrameLinker by default installs JavaScript by calling a function with a list of strings containing all the JavaScript. For Super Dev Mode, this doesn't matter because we override it in the same way as DirectInstallLinker. But for debugging GWT code outside Super Dev Mode, It's a real pain because most browser debuggers other than Chrome don't have an easy way to debug code installed in this way.

Comment #6

Posted on Mar 13, 2014 by Happy Elephant

https://code.google.com/p/google-web-toolkit/issues/detail?id=8578

Comment #7

Posted on Mar 13, 2014 by Swift Rhino

I suppose you meant https://gwt-review.googlesource.com/6618 ;-)

Comment #8

Posted on Apr 8, 2014 by Happy Elephant

How about keeping CrossSiteIFrameLinker but with a better default for installcode?

https://gwt-review.googlesource.com/#/c/6960/

(With this change, DirectInstallLinker is effectively obsolete.)

Comment #9

Posted on May 13, 2014 by Swift Rhino

Batch-assigning all FixedNotReleased issues to Milestone-2_7. Some might have been actually fixed in 2.6; chime in if that's the case.

Comment #10

Posted on Oct 30, 2014 by Massive Cat

Bulk edit: Released since GWT 2.7.0 RC1

Status: Fixed

Labels:
ReleaseNote-BreakingChange Category-SuperDevMode Milestone-2_7