Export to GitHub

fofix - issue #974

Bass Drum 3D note wider than neck


Posted on Sep 7, 2009 by Happy Rabbit

After r1854 with the fix for POV with 3D notes, the open bass note for drums appears wider than neck (it seems the same size of custom POV). This issue happens with all themes (RB2, Megalight, etc) if 3D notes are enabled with these values into theme.ini

twoDnote = False noterot1 = -2 noterot2 = -1 noterot3 = 0 noterot4 = 1 noterot5 = 2 threeDspin = False

Still happens into r1855 under Win7 Py 2.6, no log obviously but there's a screenshot.

Attachments

Comment #1

Posted on Sep 8, 2009 by Happy Elephant

This is obviously because the bass note was made for the wide neck. The question to anyone who wishes to fix this is: should the bass note be scaled to fit the width of the neck? Or should a new theme.ini option for open note horizontal scaling be added? Or should it be left up to the modeler to make the note the right size?

Comment #2

Posted on Sep 8, 2009 by Quick Horse

Hmm... actually, I didn't realize we'd added an issue for this one - check out r1858 for a possible solution.

I went with the make the models fit -a- neck, and then have all 3D objects automatically scaled to whatever random neck size is given. Sound good?

Actually, it just occurred to me (really, just...) that we could make it scale to the way the neck was set previously instead of the default. I'll do that now - you all tell me how it works (r1859, though I'm writing it before I've committed it)

Status: Fixed

Labels:
Type-Defect Priority-Low Milestone-Release-3.120 Visual