My favorites | Sign in
Project Home Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 946: Customize frequency of times in agenda slot axis
17 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Aug 2015


Sign in to add a comment
 
Reported by thyjo...@hotmail.co.uk, May 7, 2011
Easy to reproduce, new code with no tweaks, If you set slotMinutes to certain times, 15, 30, 45, the main time shows but the increment doesnt and has a blank cell, i.e for 30 mins
6am
[blank]
7am
Wheras it should show
6am
6:30
7am

It does this for all failed time events as below, but setting to intervals that work show each and every time slot time,

slotMinutes: 5 WORKS
slotMinutes: 10 WORKS
slotMinutes: 15 FAILS
slotMinutes: 20 WORKS
slotMinutes: 25 WORKS
slotMinutes: 30 FAILS
slotMinutes: 35 WORKS
slotMinutes: 40 WORKS
slotMinutes: 45 FAILS
slotMinutes: 50 WORKS
slotMinutes: 55 WORKS
slotMinutes: 60 WORKS
May 7, 2011
#1 thyjo...@hotmail.co.uk
I think ive found where its doing it, and i fixed it by commenting a line out.

Basically within the function buildSkeleton() the <th> that is created to show the time does the following:

"<th class='fc-agenda-axis " + headerClass + "'>A: " +
				((!slotNormal || !minutes) ? formatDate(d, opt('axisFormat')) : '&nbsp;') +
				"</th>" +

now where its got !minutes, that releates to:

d = zeroDate();
		maxd = addMinutes(cloneDate(d), maxMinute);
		addMinutes(d, minMinute);
		slotCnt = 0;
		for (i=0; d < maxd; i++) {
			minutes = d.getMinutes();

and an output of minutes shows 0 45 30 15.

Commenting out: minutes = d.getMinutes(); fixes it/well makes it work.

So why is that section in place?
May 8, 2011
Project Member #2 adamrs...@gmail.com
the existing behavior is that it will only show times on the hour marks (1pm, 2pm , 3pm, etc). i will see if more people want to override this behavior and provide a new setting if necessary
Summary: show all times in agenda slot axis
Status: Maybe
Labels: Type-Defect
Jun 1, 2012
#4 jayant.m...@logicspice.com
yes i am also facing this issue.Could please look on it.
Jul 24, 2012
#5 im2cool4...@gmail.com
would like to see the "feature" implemented as well.
Mar 11, 2013
#6 kevin.ly...@gmail.com
I also encountered this need.
Mar 11, 2013
#7 chris.cl...@gmail.com
I'll vote for this too.
Mar 22, 2013
#8 steeve.t...@gmail.com
I need it too.
May 24, 2013
#9 i...@giuseppecortese.it
I need it too.
Aug 7, 2013
#10 jamespst...@gmail.com
Same issue here. 
Aug 13, 2013
Project Member #11 adamrs...@gmail.com
(No comment was entered for this change.)
Summary: Show all times in agenda slot axis (was: show all times in agenda slot axis)
Status: Discussing
Labels: -Type-Defect Type-Feature
Aug 13, 2013
Project Member #12 adamrs...@gmail.com
 Issue 633  has been merged into this issue.
Aug 14, 2013
Project Member #13 adamrs...@gmail.com
 Issue 951  has been merged into this issue.
Aug 14, 2013
Project Member #14 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Aug 14, 2013
Project Member #15 adamrs...@gmail.com
(No comment was entered for this change.)
Summary: Customize frequency of times in agenda slot axis (was: Show all times in agenda slot axis)
Aug 14, 2013
Project Member #16 adamrs...@gmail.com
 Issue 1196  has been merged into this issue.
Sep 7, 2013
#17 schultz....@gmail.com
I am voting for this issue as well, thank you!
Mar 9, 2014
#18 ric...@gmail.com
Is this issue being considered yet? It would be really useful to have this setting working.
May 20, 2014
#19 pedrovin...@gmail.com
I also vote for this issue. Please consider fixing it. This would be very helpful. Thank you.
May 20, 2014
#21 pedrovin...@gmail.com
A fix for this issue will be quite easy. The problem is on the code below:

"<th class='fc-agenda-axis " + headerClass + "'>" +
((!slotNormal || !minutes) ? formatDate(d, opt('axisFormat')) : '&nbsp;') +
"</th>"


If you want to show only the hour marks (1pm, 2pm , 3pm, etc), change the code to:

"<th class='fc-agenda-axis " + headerClass + "'>" +
((!minutes) ? formatDate(d, opt('axisFormat')) : '&nbsp;') +
"</th>"

If you want to always show the time:

"<th class='fc-agenda-axis " + headerClass + "'>" +
formatDate(d, opt('axisFormat')) +
"</th>"

imho, the best solution would be add a new configuration like alwaysShowTime:true and do something like:

"<th class='fc-agenda-axis " + headerClass + "'>" +
((!minutes || alwaysShowTime) ? formatDate(d, opt('axisFormat')) : '&nbsp;') +
"</th>"

Regards,

Pedro Vaz
Jun 5, 2014
Project Member #22 adamrs...@gmail.com
Here is a pull request with an implementation of an option to show the time on every slot on the axis, via @jdwisse: https://github.com/arshaw/fullcalendar/pull/145
Jun 5, 2014
Project Member #23 adamrs...@gmail.com
Another implementation, via @boycsbaldwin:
https://github.com/arshaw/fullcalendar/pull/107
Jun 5, 2014
Project Member #24 adamrs...@gmail.com
Another implementation via @AlexKa:
https://github.com/arshaw/fullcalendar/pull/102

NOTE: i have not tested any of these pull request, nor investigated their compatibility with v2, but they are still probably worth checking out.
Jul 7, 2014
#25 johnstua...@gmail.com
15 min slots would be very useful
Jul 17, 2014
#26 paolonim...@gmail.com
I dont understand yet how to show every 15 minutes in the agendaDay. What code do i have to modify?
Jul 20, 2014
#27 windmao...@gmail.com
can we add an option "axisSlotFormat" option, so that we can change the format if we want to, something like

((!minutes) ? formatDate(d, opt('axisFormat')) : "<small>" + formatDate(d, ':mm') + "</small>") +
Sep 29, 2014
#28 develope...@gmail.com
In fullcalendar 2.1 I replace in the line 5798 
((!slotNormal || !minutes) ? 

for this code
( ( (slotNormal || minutes) || (!slotNormal || !minutes) )?

now is visible  all frequency of times
Oct 15, 2014
#29 yongha...@gmail.com
Hi develope...@gmail.com,does it wor for 2.1.1 version?Thanks 
Oct 15, 2014
#30 develope...@gmail.com
Hi yongha...@gmail.com!.. yes, It is what I am using
Nov 1, 2014
#31 christia...@gmail.com
Hi, I am using version 2.1.1 and I had to manually make this change in order for the "normal" time intervals to appear. 

Aug 22, 2015
Project Member #32 adamrs...@gmail.com
a solution to this has been implemented in fullcalendar v2.4.0, and released

the setting...
http://fullcalendar.io/docs/agenda/slotLabelInterval/

changelog for the release...
https://github.com/fullcalendar/fullcalendar/releases/tag/v2.4.0
Status: Released
Sign in to add a comment

Powered by Google Project Hosting