Export to GitHub

fullcalendar - issue #1168

Drag and drop don't work with jquery-1.7


Posted on Nov 6, 2011 by Helpful Camel

If I update the jQuery version in the demo files, d&d don't work any more, the Drop event is not called. Ideas?

Comment #1

Posted on Nov 7, 2011 by Happy Bird

It would be really nice to not have to use jquery 1.5.2 with this plugin. Dropping appears to be the primary issue with jquery 1.7. Any thoughts on when we can use the fullcalendar plugin with an up to date jquery?

PS: This is without a doubt one of the top, if not the best, jQuery plugin. Thanks!

Comment #2

Posted on Nov 15, 2011 by Quick Elephant

I have found this solution:

function draggableSlotEvent(event, eventElement, timeElement) { [...] start: function (ev, ui) { var ev = ev.originalEvent; /* added this line FIXME filipogg@gmail.com / [...] drag: function(ev, ui) { var ev = ev.originalEvent; / added this line FIXME filipogg@gmail.com / [...] stop: function(ev, ui) { var ev = ev.originalEvent; / added this line FIXME filipogg@gmail.com */ [...] }

function HoverListener(coordinateGrid) { [...] function mouse(ev) { var ev = ev.originalEvent; /* added this line FIXME filipogg@gmail.com*/ [...] } [...] }

Attachments

Comment #3

Posted on Nov 16, 2011 by Happy Cat

I can confirm the issue with after jQuery Update to 1.7 filippos solution. works like a charm.

Comment #4

Posted on Nov 17, 2011 by Swift Panda

10 points, works a treat with 1.7

Comment #5

Posted on Nov 17, 2011 by Grumpy Rhino

http://bugs.jquery.com/ticket/10816

Comment #6

Posted on Nov 18, 2011 by Swift Giraffe

implemented the fix and it worked. Thanks filippos!

Comment #7

Posted on Nov 20, 2011 by Helpful Monkey

Issue 1172 has been merged into this issue.

Comment #8

Posted on Dec 8, 2011 by Happy Dog

Got burned by this issue too... I'll get the source from github, but how about an official release of full-calendar? Thanks!

Comment #9

Posted on Dec 12, 2011 by Massive Rabbit

The issue is caused by a change in the regular expression which is used to normalize 'mouse event properties' in the Event object: https://github.com/jquery/jquery/blob/master/src/event.js#L7

Dragging an event in fullcalendar binds a 'drag' event in HoverListener::start(), and that doesn't match the regexp in jQuery, so the pageX/Y coordinates are not copied to the 'root' of the Event object.

(fullcalendar.js line 4083) hoverListener.start([...], ev, 'drag');

(fullcalendar.js line 5143) t.start = function(_change, ev, _bindType) { change = _change; firstCell = cell = null; coordinateGrid.build(); mouse(ev); bindType = _bindType || 'mousemove'; $(document).bind(bindType, mouse); };

Solution of filippos works, but I'm not sure if this will work in all browsers, as jQuery does the normalizing for keeping browser consistency.

An other solution is to always use 'mousemove' instead of 'drag' as the event type.

Comment #10

Posted on Dec 21, 2011 by Grumpy Wombat

Any word on a official release with a fix for this?

Comment #11

Posted on Dec 21, 2011 by Massive Giraffe

It may appear that filippos fix works but Its not exactly whats needed in global. It may solve problems with drag&drop but an error appears in IE8 with selection, apparently IE8 has some issues with using ev.originalEvent for triggering selection handler. However, as famousin said, using 'mousemove' instead of 'drag' solves all problems, at least I tried it and both, d&d and selection, work as charm (tested in newest versions of Chrome, FF, Opera, Safari and IE8).

Comment #12

Posted on Jan 10, 2012 by Helpful Monkey

Issue 1144 has been merged into this issue.

Comment #13

Posted on Feb 7, 2012 by Grumpy Camel

Jan and Famousin, is there anyway that you can attach your .js file for this? I'm not sure where to replace the 'drag' with the 'mousemove' all are. I tried to make the updates that famousin made but it still doesn't work in IE so I'm obviously missing something. Thanks for the help.

Comment #14

Posted on Feb 7, 2012 by Helpful Monkey

there is an official release for this fix: v1.5.3 http://arshaw.com/fullcalendar/download/ thanks for the patience

Comment #15

Posted on Aug 14, 2012 by Quick Rhino

Doesn't*

Comment #16

Posted on Oct 11, 2012 by Quick Monkey

It is broken in the latest version, but a very simple fix by comment #9 works:

Search for 'drag' Replace all 3 with 'mousemove'

Problem solved.

Comment #17

Posted on Apr 3, 2013 by Quick Dog

Hi everybody, i have the same problem, i created a calendar on a simple web page and i'm trying to put it on my website. I use thoses files :

and the fullcalendar.js. The drag and drop doesn't work so i tried to fix it by replacing "drag" by "mousemove" but it's still not working....Anybody could help me? Thanks

Comment #18

Posted on Aug 14, 2013 by Helpful Monkey

(No comment was entered for this change.)

Status: Released

Labels:
Type-Bug