Export to GitHub

btstack - issue #441

Patch for /trunk/src/rfcomm.c


Posted on Feb 9, 2015 by Swift Rhino

In API Definition, rfcomm_send_packet_for_multiplexer(multiplexer, address, BT_RFCOMM_SABM, 0, NULL, 0); used one of the function parameter as the Macro BT_RFCOMM_SABM. I thought of it seems to be a Bug, you may either modify the API definition with suitable function parameter other than Macro.

Attachments

Comment #1

Posted on Feb 17, 2015 by Swift Ox

Hi

can you explain a bit more?

in many functions like rfcomm_send_sabm I use a #define / macro as a constant value

Comment #2

Posted on Feb 18, 2015 by Swift Rhino

As per the API Definition: int rfcomm_send_packet_for_multiplexer(rfcomm_multiplexer_t *multiplexer, uint8_t address, uint8_t control, uint8_t credits, uint8_t *data, uint16_t len){ }

Above API, called many times with in the file /trunk/src/rfcomm.c, as rfcomm_send_packet_for_multiplexer(multiplexer, address, BT_RFCOMM_SABM, 0, NULL, 0);

here Fuintion parameter uint8_t as BT_RFCOMM_SABM.

Status: Started

Labels:
Type-Patch