Export to GitHub

btstack - issue #414

Wrong definitions in hci_cmds.h


Posted on Aug 23, 2014 by Happy Monkey

I was confused because of some result code after the L2CAP Connection Response signalling command. I received 0x67 which is 0x63+4=0x67. The correct error code would be L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_RESOURCES.

But please see the current definitions in hci_cmds.h:

define L2CAP_CONNECTION_RESPONSE_RESULT_SUCCESSFUL 0x63

define L2CAP_CONNECTION_RESPONSE_RESULT_PENDING 0x64

define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_PSM 0x65

define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_SECURITY 0x66

define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_RESOURCES 0x65

define L2CAP_CONNECTION_RESPONSE_RESULT_RTX_TIMEOUT 0x66

I assume a copy&paste bug.

Comment #1

Posted on Aug 25, 2014 by Happy Monkey

I guess that this issue can be closed. It was fixed in the SVN.

Comment #2

Posted on Aug 25, 2014 by Swift Ox

thanks (still trying how the auto-close feature works)

Status: Fixed

Labels:
Type-Defect Priority-Medium