
specs - issue #171
Changes to the Notifier-Interface in 1.6.7 broke specs runner in idea
What steps will reproduce the problem?
Try to run a specification from idea
What is the expected output? What do you see instead?
Exception in thread "main" java.lang.AbstractMethodError: org.jetbrains.plugins.scala.testingSupport.specs.JavaSpecsNotifier.runStarting(Lscala/Function0;)V at org.specs.runner.NotifierRunner$$anonfun$report$1.apply
What version of the product are you using? On what operating system? 1.6.7
This obviously happened because the parameter of runStarting was changed to be by-name. You could argue that instead the idea runner should be changed but that would probably introduce issues for everyone running old versions of specs.
Comment #1
Posted on Jan 17, 2011 by Massive GiraffeI fixed this issue by having a different implementation for the sbt testrunner which is using the NotifierRunner as well. Please find the changes in the latest SNAPSHOT version.
Comment #2
Posted on Jan 20, 2011 by Massive LionThanks, Eric for the quick fix. I tried it and it seems to work.
Comment #3
Posted on Jan 20, 2011 by Quick LionFor what is worth, I had filed the following:
Comment #4
Posted on Jan 20, 2011 by Quick LionIs there a plan to release 1.6.8 relatively soon? If so, then I will close that issue in the jetbrains tracker because if they fix it, it will break it again!
Comment #5
Posted on Jan 20, 2011 by Massive GiraffeI did the unthinkable, I redeployed a version of 1.6.7 with the fix because it was close to useless without.
Comment #6
Posted on Jan 20, 2011 by Quick LionOh, I see. Hmm, this is going to cause some weird support issues as whoever had already updated to 1.6.7 and has not seen this will have different behaviour than the ones that have updated to 1.6.7 after that.
And the fix is not nice either (e.g. I have to tell others at work to delete their dependency manually). In these cases, I suggest releasing a 1.6.7.1 or something like that.
Comment #7
Posted on Jan 20, 2011 by Massive GiraffeYou're certainly right.
I just gave an explanation on the mailing list of why I did it, but seeing your comment and thinking about it, I think that next time I'll go for:
- a 1.6.7.1 version
- a note on the website explaining the situation and giving the relevant links if I can't go for a full release
Comment #8
Posted on Jan 20, 2011 by Quick LionI don't want to be a messenger of more bad news, but the Maven central repo still has the first version of 1.6.7 you deployed:
http://repo1.maven.org/maven2/org/scala-tools/testing/specs_2.8.1/1.6.7/
I don't think they allow non-snapshot repos to be updated after the fact. I suggest releasing 1.6.7.1 if you can.
Comment #9
Posted on Jan 20, 2011 by Massive CamelI just patched IDEA to work with 1.6.6 and 1.6.7. No need to change Specs.
Comment #10
Posted on Jan 20, 2011 by Quick LionThanks!
Comment #11
Posted on Jan 20, 2011 by Massive GiraffeJason, you're so fast, I should have waited!
Just for my knowledge can you tell how you fixed it?
Comment #12
Posted on Jan 20, 2011 by Quick LionStatus: Fixed
Labels:
Type-Defect
Priority-Medium