Export to GitHub

protobuf-dt - issue #110

ui plugin depends on test plugin

Posted on Sep 13, 2011 by Grumpy Rhino

What steps will reproduce the problem? 1. Load the ui and test projects 2. Observe that com.google.eclipse.protobuf.ui.commands.CommentNodesFinder depends on com.google.eclipse.protobuf.junit.util.SystemProperties.lineSeparator() 3.

What is the expected output? What do you see instead? UI should not depend on Test

What version of the product are you using? On what operating system? 1.0.1

Please provide any additional information below. Simple fix, just lookup the system line separator directly in CommentNodesFinder.

private static final String LINE_SEPARATOR = System.getProperty("line.separator");

... String[] comment = rawComment.split(LINE_SEPARATOR); ...

Comment #1

Posted on Sep 13, 2011 by Grumpy Rhino

(No comment was entered for this change.)

 Attachments

Comment #2

Posted on Sep 13, 2011 by Grumpy Cat

(No comment was entered for this change.)

Comment #3

Posted on Sep 13, 2011 by Grumpy Cat

r18341fe53dfa

Status: Fixed

Labels:
Type-Defect Priority-Medium Milestone-Release-1.0.2