Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for growl notifications #33

Closed
minj opened this issue Mar 19, 2015 · 8 comments
Closed

Error for growl notifications #33

minj opened this issue Mar 19, 2015 · 8 comments

Comments

@minj
Copy link
Owner

minj commented Mar 19, 2015

Original issue 33 created by larswortel on 2008-12-16T09:00:55.000Z:

What steps will reproduce the problem?

  1. Log in to Hattrick.org

What is the expected output? What do you see instead?
I expect a growl notification saying 'Welcome larsw84'. Instead, nothing
happens. The console displays the following error:
FoxtrickAlert.js run: TypeError: doc is undefined

Using the latest 45f6b46 r158).

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #1 originally posted by larswortel on 2008-12-16T09:09:40.000Z:

Update: fixing the error above was easy: the run function of foxtrickalert.js
requested two parameters (page, doc) whereas it only gets one from foxtrick.js
because it's a run-on-every-page function (namely doc). This is fixed in 33c53b4 r159...
but unfortunately the notifications still do not work.

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #2 originally posted by larswortel on 2008-12-16T09:17:59.000Z:

Spoke too soon: just got a notification :) I guess my fix was sufficient after all.

Status: Fixed

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #3 originally posted by tiziano.m on 2008-12-16T10:24:05.000Z:

I reopen it because there is a bug: notifications don't work if the entries in the
news aren't 3. As stated before, i should stop writing code at 2 o'clock in the
night. I'll work on it.

Status: Started

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #4 originally posted by tiziano.m on 2008-12-16T11:53:44.000Z:

The bug for lines<3 is fixed. Now there are 2 smaller bugs:
if you receive 2 news at the same time, just one is shown.
when you open the page the first time, if there is a notification to be shown, you'll
get it not immediately but at first refresh (after 30sec)

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #5 originally posted by tiziano.m on 2008-12-16T12:32:43.000Z:

Also playsound seems not working

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #6 originally posted by tiziano.m on 2008-12-17T23:42:21.000Z:

playsound fixed (thanks kolmis). Still not working:
-if you get 2 news at the same time only last one is shown
-there is a delay between news is shown and the notification pop

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #7 originally posted by larswortel on 2009-01-15T19:06:27.000Z:

Finally fixed now in 9df28b4 r880

@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #8 originally posted by larswortel on 2009-01-15T19:06:52.000Z:

<empty>

Status: Fixed

@minj minj closed this as completed Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant