Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player coloring not working for derby matches #1

Closed
minj opened this issue Mar 19, 2015 · 1 comment
Closed

Player coloring not working for derby matches #1

minj opened this issue Mar 19, 2015 · 1 comment
Labels
bug Priority-Medium

Comments

@minj
Copy link
Owner

minj commented Mar 19, 2015

Original issue 1 created by larsts on 2008-04-06T16:19:12.000Z:

What steps will reproduce the problem?

  1. Check a derby match, example matchid 162909227
    (https://www.hattrick.org/goto.ashx?path=/Common/MatchDetails.aspx%3FmatchID%3D162909227%26amp%3BuseArchive%3DTrue)

What is the expected output? What do you see instead?
Should see player coloring, no coloring is added.

What version of the product are you using? On what operating system?
Foxtrick 0.3.64, FF 2.0.0.13, Windows XP.

Please provide any additional information below.

For derby matches, Hattrick now adds a link to the region the teams are in.
From the example: People from all over Oslo had joined up for the derby.

Extraction of the variables TeamA and TeamB in matchDetailPlayerColoring()
fails with the extra region nodes in the DOM.
@minj
Copy link
Owner Author

minj commented Mar 19, 2015

Comment #1 originally posted by kolmis on 2008-05-20T12:46:56.000Z:

fixed in 61a6eaa r53
61a6eaa r53

Status: Fixed

@minj minj closed this as completed Mar 19, 2015
minj pushed a commit that referenced this issue Nov 12, 2018
@ventouris
Merge pull request #1 from minj/master
d88bda9 
Merge from Foxtrick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minj