Posted on May 21, 2014 by
Happy Dog
There are a few places in the code that could be cleaned up:
- There are defined variables that are never used
- Some places where semicolon use is not consistent
- There is another duplicate test case
Comment #1
Posted on May 22, 2014 by Happy Doghttps://github.com/mrennie/esprima/commit/6d2082d07a78997f7b7611cadb99796fea575a9b
All tests pass.
Comment #2
Posted on May 22, 2014 by Quick RabbitGood catch! Is there a way to tweak our ESLint configuration so that those are caught automatically as well?
Comment #3
Posted on May 22, 2014 by Happy DogI could investigate. The ESLInt in Orion is not stock - we have modified it and provide our own custom rules, but perhaps there are similar rules.
Comment #4
Posted on May 22, 2014 by Happy DogI opened issue 548 to track the ESLint updates (if any)
Comment #5
Posted on May 25, 2014 by Quick RabbitIssue 545: Code cleanup https://github.com/ariya/esprima/commit/6d2082d07a
Status: Fixed
Labels:
Type-Defect
Priority-Medium