Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding entrypoints from the dart2js transformer #14594

Closed
sethladd opened this issue Oct 29, 2013 · 15 comments
Closed

Allow excluding entrypoints from the dart2js transformer #14594

sethladd opened this issue Oct 29, 2013 · 15 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

Currently, pub build finds all .dart files in web/ with a main(). I want the fastest builds, so I'd like to say which files I want compiled.

I'd like a way to specify the entry points that I want pub build to process
.

@munificent
Copy link
Member

I want the fastest builds, so I'd like to say which files I want compiled.

If you got the fastest builds some other (for purposes of discussion magical) way, would you still care to control which files are compiled? Can you frame this bug in terms of the problem you're running into?


Added this to the Later milestone.

@sethladd
Copy link
Contributor Author

Sure, performance aside. (although, that's a big part of this. compiling to JS is non trivial)

Let's say I have App A, but experiment E. E might be busted, only works in Dartium, won't be deployed, just for me. I don't want to slow down the build, introduce extraneous error messages or warnings, or break the build if all I care about is App A.

So I guess this is about cycle times mostly, and reducing warnings/output about broken builds that I know are broken.

@munificent
Copy link
Member

Issue #15255 has been merged into this issue.

@munificent
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-Medium label.

@munificent
Copy link
Member

Removed Priority-Medium label.
Added Priority-High label.

@munificent
Copy link
Member

Marked this as blocking #15829.

@nex3
Copy link
Member

nex3 commented Jan 10, 2014

I believe the current plan for issue #14673 will cover this use case. As such, can we close out this bug?

@munificent
Copy link
Member

We now let you specify which directory you want to build, but not which entrypoints.

This ticket is a bit vague. If you specify some entrypoint, presumably you do also want all of the other assets needed by that entrypoint. Is it more that you want to exclude certain entrypoints from being compiled using dart2js?

@sethladd
Copy link
Contributor Author

Sure, excluding entry points would help. See https://code.google.com/p/dart/issues/detail?id=14594#c2 In that case, I wanted to say "don't build this thing, it's busted and I know it"

@munificent
Copy link
Member

OK, retargeting the bug.


Changed the title to: "Allow excluding entrypoints from the dart2js transformer".

@munificent
Copy link
Member

I'm gonna start poking at this. My plan is to add support for $exclude and $include to transformers in general, and then we'll get dart2js for free.


cc @nex3.
Set owner to @munificent.
Added Started label.

@munificent
Copy link
Member

$include and $exclude are in.


Added Fixed label.

@sethladd
Copy link
Contributor Author

thanks!

We might want to document this. CC'ing Sharon.


cc @Sfshaza.

@munificent
Copy link
Member

@sethladd sethladd added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 27, 2014
@sethladd sethladd added this to the Later milestone Feb 27, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#691.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants