Export to GitHub

xar - issue #43

xar_extract_tobuffer does not free the returned buffer when an error occured.


Posted on Oct 16, 2007 by Swift Giraffe

That's not really an error. It just would be smarter if xar_extract_tobuffersz() did something like this:

int err = xar_arcmod_extract(x,f,NULL,*buffer,*size); if (err != 0) { *size = 0; free(buffer); *buffer = NULL; } return err;

It would remove the need to to it in each caller.

Comment #1

Posted on Oct 16, 2007 by Happy Dog

Excellent suggestion, this has been resolved with commit 189.

Status: Fixed

Labels:
Type-Defect Priority-Medium