Export to GitHub

wxlauncher - issue #97

FS2NET account data is not persistent in game


Posted on Dec 10, 2012 by Helpful Ox

What steps will reproduce the problem? -start the game -select pilot profile for multiplayer -go to "options" > Multi -click on "PXO" and enter name and password -click on "accept -click on "start multiplayer", play multiplayer match... - quit the game -repeated step 2 to 3 -PXO data empty

What is the expected output? What do you see instead?

What version of the wxLauncher are you using: What version of fs2_open: What mods (and version, if known):

What operating system and version: Mac/Linux

Please provide any additional information below.

Related to http://scp.indiegames.us/mantis/view.php?id=2750 http://www.hard-light.net/forums/index.php?topic=63609.100

Comment #1

Posted on Dec 10, 2012 by Massive Rabbit

This may also happen on Windows, we just haven't verified it doesn't yet.

Comment #2

Posted on Dec 15, 2012 by Grumpy Bear

I think I see what's happening. Whenever someone presses the launcher's Play button, wxL writes out the contents of the profile to fs2_open.ini/registry and cmdline_fso.cfg, and currently, PXO data is not stored in wxL profiles.

I suspect that this issue doesn't occur in Windows, because updating the registry is done on a key-by-key basis, while on OS X/Linux, the entire fs2_open.ini file is overwritten, which would clobber any saved PXO data.

A fix might not be trivial, since it'd likely require reading in the fs2_open.ini file and making key-by-key updates. Hard to say offhand how hard it'd be to refactor the code to do that, although wxWidgets includes good support for manipulating .ini files.

Comment #3

Posted on Dec 15, 2012 by Grumpy Bear

Here's an experimental patch. Please back up your wxL profiles folder (~/Library/Application Support/wxlauncher on OS X or ~/.wxlauncher on Linux) before applying the patch or using a patched version. The patch has no effect on Windows builds.

I can put up an OS X binary and PM the link if needed, but I'd rather not post it publicly, since I don't want random test builds floating around.

Attachments

Comment #4

Posted on Dec 16, 2012 by Massive Rabbit

Your test build worked fine for me on OSX. Fixed the launcher's recognition/saving of the bandwidth settings and kept it from overwriting the in game PXO auth.

Comment #5

Posted on Dec 18, 2012 by Happy Rabbit

Comment deleted

Comment #6

Posted on Dec 18, 2012 by Happy Rabbit

It worked for me too. Thanks for your code.

Cheers, the one who filed the bug. :-)

Comment #7

Posted on Dec 19, 2012 by Grumpy Bear

This issue was closed by revision 17453e162c85.

Comment #8

Posted on Dec 19, 2012 by Grumpy Bear

Patch has been committed. Thanks to everyone who tested it.

Status: Fixed

Labels:
Type-Defect Severity-High OpSys-Linux OpSys-OSX Component-Persistence