Export to GitHub

wxlauncher - issue #68

New profiles are overwriting existing profiles


Posted on Nov 17, 2011 by Swift Rabbit

What steps will reproduce the problem? 1. Starting with 4 profiles, create a new profile (or clone an existing one) 2. Make settings changes (e.g. select exec, change mod, changing lighting presets) 3. Save profile 4. Run FSO & exit 5. Confirm there are 5 profiles 6. Close wxlauncher 7. Re-open wxlauncher - only 4 profiles now exist

What is the expected output? What do you see instead?

Expect to see 5 profiles

What version of the wxLauncher are you using: changeset: 786:3390ab669673 What version of fs2_open: various, e.g. 3.6.14 RC1, Antipodes 8 What mods (and version, if known): various, e.g. windmills, mediavps_3612

What operating system and version: Ubuntu 10.04

Please provide any additional information below.

Here's some details from the .wxlauncher directory:

Before starting the procedure above: ~/.wxlauncher/pro00000.ini:name=Default ~/.wxlauncher/pro00000.ini:filename=pro00000.ini ~/.wxlauncher/pro00002.ini:name=test ~/.wxlauncher/pro00002.ini:filename=pro00002.ini ~/.wxlauncher/pro00003.ini:name=debug-WoD ~/.wxlauncher/pro00003.ini:filename=pro00003.ini ~/.wxlauncher/pro00004.ini:name=test2 ~/.wxlauncher/pro00004.ini:filename=pro00004.ini

After completing the procedure above: ~/.wxlauncher/pro00000.ini:name=Default ~/.wxlauncher/pro00000.ini:filename=pro00000.ini ~/.wxlauncher/pro00002.ini:name=test ~/.wxlauncher/pro00002.ini:filename=pro00002.ini ~/.wxlauncher/pro00003.ini:name=debug-WoD ~/.wxlauncher/pro00003.ini:filename=pro00003.ini ~/.wxlauncher/pro00004.ini:name=test3 ~/.wxlauncher/pro00004.ini:filename=pro00004.ini

Note that pro00004.ini has changed from test2 to test3

Note that pro00001.ini seems to be missing

Please let me know if you need any other information

Comment #1

Posted on Nov 17, 2011 by Swift Elephant

Reading the source that handles the profile creation/deletion the cause is obvious. The solution... is less trivial.

In the meantime, the issue is exactly that there is a gap in the numbering of pro*.ini files, so a workaround would be to rename the highest numbered pro*.ini file to fill in the gap. The order doesn't matter as long as the file numbers are contiguous.

Comment #2

Posted on Nov 17, 2011 by Swift Rabbit

Thanks for the workaround - I've tested by doing a pro*04.ini rename to pro*01.ini & updated the filename entry inside the file the same way. After doing that, steps 1-6 from the description work as expected.

Comment #3

Posted on Apr 22, 2012 by Grumpy Bear

This issue was closed by revision 8bc4b0c44bd4.

Comment #4

Posted on Apr 22, 2012 by Grumpy Bear

Please let us know whether the patch solves your issue.

Comment #5

Posted on Apr 26, 2012 by Swift Rabbit

Thanks jg18 - that seems to have fixed the problem.

Status: Fixed

Labels:
Type-Defect Severity-Critical OpSys-All Milestone-Release0.9 Component-Logic Usability