Export to GitHub

wave-protocol - issue #251

Text inside blips is not wrapped


Posted on Apr 4, 2011 by Happy Cat

The text inside blips is not wrapped, so if you type too much chars the the text overflows and is not rendered. What steps will reproduce the problem? 1.Create a new blip. 2. Hit some key on the keyboard and keep pressing until the text reaches the end of the blip border. What is the expected output? What do you see instead? Expected: the text gets wrapped and excess chars rendered on a new line. Actual: the text is not wrapped.

Comment #1

Posted on Apr 5, 2011 by Helpful Hippo

Note that cross-browser HTML support for breaking a single long word was quite limited back when we encountered this issue with Google Wave, and we decided just to let the text run over the edge (but be hidden).

Looking at the issue again, IE has { word-wrap: break-word; } for a while. I'm not sure what other browsers have support it, but it looks like it made it into CSS3: http://www.w3.org/TR/2011/WD-css3-text-20110215/#word-wrap0

The union of CSS3-supporting browsers and IE probably covers everything worth caring about.

Comment #2

Posted on Apr 19, 2011 by Happy Cat

This issue seems to be adequate to be labeled as starter project. Tip: take a look at: src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Blip.css Also, note that there is "mock" folder one level above that allows to play with blip mocks. First make changes on the mocks, and then also update the actual css.

Comment #3

Posted on Apr 29, 2011 by Helpful Camel

Comment deleted

Attachments

Comment #4

Posted on Apr 29, 2011 by Happy Cat

There a problem with screenshot, I just see a text: "Attachments: blip_word_wrap.png 20.1 KB" without attachment.

Comment #5

Posted on May 6, 2011 by Helpful Camel

Added a fix. http://codereview.waveprotocol.org/585002

Comment #6

Posted on May 6, 2011 by Happy Cat

Please add corresponding comment on the Wave Jira at https://issues.apache.org/jira/browse/wave

Status: Fixed

Labels:
Type-Defect Priority-Medium StarterProject