Attached a patch to make the base URL of WIAB configurable (as we talked yesterday in the office hours).
The goal is to permit something like: http://127.0.0.1:9898/otherdir/ where <otherdir> it configurable via the server.config file.
The attached patch it's a work in progress. Now the login/register gxp pages are working (with "/" or "/otherdir/" as base url) and the servlets are listening to the configurable URLs. Also I pass a __baseUrl parameter to the client in the same way that __useSocketIO.
But in the client it's necessary more work in order to close this issue. For instance the client starts to load: /socket.io/socket.io.js instead of /otherdir/socket.io/socket.io.js because this patch is generated from a external jar and I think is not configurable.
Any tips to follow?
- baseurl.patch 25.8KB
Comment #1
Posted on Jan 21, 2011 by Massive BearCould you upload a patch to our code review tool so we can make comments in context?
Instructions at http://www.waveprotocol.org/code/submitting-code
Comment #2
Posted on Jan 21, 2011 by Quick HippoThanks for the link.
Here a clone with my changes: https://code.google.com/r/vruizjurado-wiab-integration/source/detail?r=572e6f893f89898fb28239df577afb8ea7a99b02
(You can change the issue as enhancement better than defect)
Comment #3
Posted on Jan 27, 2011 by Helpful HippoWere you able to run the request_code_review.py script from the instructions above?
Comment #4
Posted on Jan 27, 2011 by Quick HippoWell I only followed the part "More complicated patches - making a clone" without the script. It's necessary also with clones?
Status: New
Labels:
Type-Defect
Priority-Medium