Export to GitHub

wave-protocol - issue #185

inserting letters with acute accents as password makes the server crash


Posted on Dec 20, 2010 by Helpful Monkey

What steps will reproduce the problem? 1. Click "Register a new account". 2. Type a user-name. 3. Type a password containing letters with acute accents. example: "á", "áéíóú" 4. Click "Register".

or

  1. Type a user-name.
  2. Type a password like one of the above.
  3. Click "Sign In"

What is the expected output? What do you see instead? I expected an alert saying that you can't use those characters (when I first registered the password), or that I can sign in successfully to my newly-created account.

What I see is HTTP ERROR: 500

Problem accessing /auth/register. Reason:

!utf8

What changeset or version are you using? On what operating system? changeset - 766:88951b7f1ff1 Archlinux 64bit.

Comment #1

Posted on Dec 20, 2010 by Massive Bear

Joseph, any chance you could take a look? Assign back to me if not.

Comment #2

Posted on Dec 20, 2010 by Helpful Monkey

Comment deleted

Comment #3

Posted on Dec 20, 2010 by Helpful Monkey

Comment deleted

Comment #4

Posted on Dec 20, 2010 by Helpful Monkey

nevermind the deleted comments.

Comment #5

Posted on Dec 20, 2010 by Massive Bear

Oh, jaosorior, if you would like to fix it please do! I can't assign the issue to you due to a technical limitation of this tracker, but go for it!

Comment #6

Posted on Dec 23, 2010 by Helpful Monkey

alright, fixed. To whom should I send the code to be reviewed?

Comment #7

Posted on Dec 23, 2010 by Helpful Monkey

here's the patch: http://codereview.waveprotocol.org/450001

Comment #8

Posted on Dec 24, 2010 by Massive Bear

(No comment was entered for this change.)

Status: Fixed

Labels:
Type-Defect Priority-Medium