Export to GitHub

vwkvasdopager - issue #7

Multiple monitor support


Posted on Oct 22, 2009 by Happy Camel

What steps will reproduce the problem? 1. Attach multiple monitors to machine 2. Notice pager only recognizes outline of primary monitor, resulting in weird display

What version of the product are you using? On what operating system?

0.4.3a on Windows XP

Please provide any additional information below.

Attached patch fixes for me.

Attachments

Comment #1

Posted on Jun 4, 2010 by Happy Bird

Doung's patch only works if the primary monitor is the top-leftmost. Other multi-monitor arrangements requires adjusting the return value of GetWindowRect().

I've prepared an alternative patch that handles this case better.

Attachments

Comment #2

Posted on Jun 4, 2010 by Happy Bird

Here's a screenshot of vwkvasdopager with my patch applied. This run on a dual-monitor box with both screens in an horizontal arrangement.

Without that patch the thumbnails only displays what's on the main screen.

Attachments

Comment #3

Posted on Jun 18, 2010 by Happy Bird

There was an error in my previous patch. I wrote lpRect->right in one place where it should be lpRect->bottom. Because of this the thumbnail displayed incorrectly when the main monitor was not the topmost.

Sorry about that..

I'm submitting a corrected version of the patch.

Attachments

Comment #4

Posted on Jun 19, 2010 by Happy Bird

Updating the patch again to remove an unreferenced local variable declaration.

Attachments

Comment #5

Posted on Jun 19, 2010 by Happy Bird

Attaching a patched binary in case anyone wants to try this.

Only vwKvasdoPager.exe is affected. You can use vwKvasdoPagerBand.dll from the 0.4.3a distribution.

Attachments

Comment #6

Posted on Jul 17, 2010 by Happy Camel

the patch is applied, problem fixed

Status: Fixed

Labels:
Type-Defect Priority-Medium