
ubuntu-system-panel - issue #25
Application icon not reflecting what's set in Main Menu
What steps will reproduce the problem? 1. Add a custom launcher to the main menu 2. Assign a custom icon to that launcher
What is the expected output? What do you see instead? The icon assigned to the launcher should be shown in USP, but instead I see the standard launcher icon. An example is attached. The command is "doom3 +set fs_game d3xp" and the icon is "/usr/share/icons/doom3roe.png".
What version of the product are you using? On what operating system? 2.00SVN, Ubuntu 9.10, but had this problem in 9.04 too.
- Screenshot.png 570.33KB
Comment #1
Posted on Sep 9, 2009 by Massive MonkeyJust looked at the screenshot I included - why is the name of the Resurrection of Evil launcher being cut so short when there's so much width left in Applications?
Comment #2
Posted on Sep 13, 2009 by Massive WombatAs a quick fix try moving the icon to the folder that is being used by your theme and just using doom3roe as the icon name. It's been a while since I looked at the launcher code so I can't be sure but I think custom paths in the icons was not implemented. I will check it out as soon as poss.
I will post back when a fix is committed.
Hope this helps.
Comment #3
Posted on Sep 25, 2009 by Massive WombatComment deleted
Comment #4
Posted on Sep 25, 2009 by Massive WombatI have just downloaded the icon and added it to my system I changed the avant-window-navigator icon to it. I have attached a screenshot to show it is doing as expected and showing it in Applications.
The only time this occurs is if there are spaces after the Icon and = sign in the .desktop file check this is not the case. nano or gedit the actual .desktop file and check it reads like this: Icon=/usr/share/icons/doom3roe.png and not: Icon = /usr/share/icons/doom3roe.png
Please let me know if this solves the problem for you.
Hope this helps.
- Screenshot-DoomRoe.png 158.43KB
Comment #5
Posted on Sep 25, 2009 by Massive MonkeyI had a look and there was no space in it, but I found something else. When I dragged a launcher from my gnome menu onto my desktop it wasn't showing the correct icon on the desktop either. I opened it in gedit and found out why: it had the correct value for "Icon[en_GB]" but not for "Icon". Thing is, this time it was fine for Doom3RoE but not for another one (similar - it was an application in my opt directory and an icon I'd downloaded and saved in /usr/share/icons). Anyway, sounds like this is a problem with gnome creating launchers doesn't it?
Comment #6
Posted on Sep 29, 2009 by Massive WombatIt might be worth filing that as a bug against gnome then. I'm glad it wasn't a USP problem, although it did get me to add code to handle spaces in the .desktop files which I have been meaning to do for ages. So thanks. :)
Comment #7
Posted on Sep 29, 2009 by Massive MonkeyIf it happens again I'll raise it in Gnome, but I can't make it happen with any new launchers I create, perhaps it's been fixed :)
Oh, but it was showing the correct icon in the standard gnome menu, so perhaps it's expected that if there's an entry for "Icon[something]" that should be used, especially if "something" is the current langauge.
Also, in my screenshot you could see the name of the application was being cut off way before the outside width of the Applications plugin. That's easily replicate-able - shall I raise that as a new bug?
Comment #8
Posted on Oct 2, 2009 by Massive WombatThe button width is an issue which I keep coming back to. The problem is that we have to restrict it some way or the buttons could end up huge. At the moment it uses a standard length after which the text is truncated (...) This is not affected by changes to the width of the plugin. However a few people have asked about altering the /height/ of the buttons too so that they can reclaim some space back and fit more buttons on screen at once. So I think a height/width setting of some sort is on the cards. Whether this will make it into USP2 or will have to wait until USP3 I can't say yet as I don't know how much time I will get at coding in the next month or two.(busy,busy) :) I'm marking this as Fixed as the other problem is unrelated. If you want to start a bug for the button width problem feel free but I will put it on my list anyway.
Thanks again for the feedback. Malac
Comment #9
Posted on Oct 2, 2009 by Massive MonkeyDo you need any help? I'm primarily a Java programmer, but I'm sure I can learn whatever USP is written in easily enough, Python is it? I might have done a bit of that actually...
Comment #10
Posted on Oct 5, 2009 by Massive WombatFeel free to dive in at any point :) We are always open to any ideas or code change suggestions that will make USP a better menu. Just submit any changes via pm on the Ubuntu Forums or here as patches. The plugins are probably the easiest to start with and there is a template file in the SVN for these. USP is written in Python and if you've already programmed in Java is really easy to pickup. Thanks again, Malac.
Status: Fixed
Labels:
Type-Defect
Priority-Medium