Export to GitHub

tongue-tied - issue #82

Deletion of a translation failed


Posted on Oct 27, 2009 by Massive Lion

Version Info TongueTied: 1.3.0 OS: Windows XP Java: 6 Browser: IE Explorer 6.0

What steps will reproduce the problem? 1. Add a translation with the same language and country, but with a different bundle 2. Delete the created translation by clicking on the "stop" icon on the left of the translation (in the window "Keyword details") 3. Confirm the deletion. 4. The window will return to the Tonguetied main window, but the translation is still there.

What is the expected output? What do you see instead? The translation should be removed, but it is still there after the deletion.

What version of the product are you using? On what operating system? See list

Please provide any additional information below. Bug is also present is previous version of Tonguetied (1.1.x, 1.2.x)

Comment #1

Posted on Oct 27, 2009 by Massive Lion

Forgot to mention that I use MySQL 5.x with Tonguetied v1.3.0

Comment #2

Posted on Oct 28, 2009 by Happy Giraffe

Further investigation. This only seems to happen for newly created keywords. For saved/existing keywords this does not happen. Steps to reproduce: 1. Create new keyword by clicking on one of the create keyword links. DO NOT save the keyword 2. On the keyword screen, click on the "Add Translation" button 3. Fill in the translation properties as described above 4. Delete the new translation by clicking on the delete icon 5. Click "OK" on the dialog box

Comment #3

Posted on Oct 28, 2009 by Happy Giraffe

(No comment was entered for this change.)

Comment #4

Posted on Oct 28, 2009 by Massive Lion

The problem also occurs on saved translations.

I am not able to delete any translation in the "keyword Details" view.

Comment #5

Posted on Dec 8, 2009 by Happy Giraffe

Comment deleted

Comment #6

Posted on Dec 8, 2009 by Happy Giraffe

This error seems to happen on modified unsaved translations with non default values.

Prerequisites: A keyword exists with translations.

Steps to reproduce: 1. Open keyword from main keywords list screen. 2. Click on the "Add translation" button. 3. Modify one or all of the Language/Country/Bundle to a value other than "Default". This is important. When the value is set to default then the delete works as expected. 4. Click on the delete translation icon. 5. Confirm that the translation still exists.

Obviously the keyword should be deleted.

Comment #7

Posted on Dec 8, 2009 by Happy Giraffe

One other observation, the translation will delete the second time that the delete icon is pressed.

Comment #8

Posted on Dec 9, 2009 by Happy Giraffe

When a translation was modified, but unsaved, the delete operation was trying to match the translation on business key and hence failing. I have added a comparator to match on translation id rather than business key.

Comment #9

Posted on Dec 14, 2009 by Massive Lion

Hi there,

I tested this issues with 1.3.1 but it is still not possible to delete a translation by pressing the icon.

My situation: keyword=f_apply then I have two languages "Default" and "Nederland". I also have two bundles using different strings for the keyword, see attached screenshot.

I tried to delete the second row "Default" "Default" "TDL" "Apply", by pressing the red icon on the left side of the row. After confirming "Ok" in the popup window the main window (keyword window) is shown, but nothing is deleted.

Please re-test on your side!

Attachments

Comment #10

Posted on Dec 15, 2009 by Happy Giraffe

Hi Rene,

Thanks for the feedback. I really appreciate it. I am struggling to reproduce the issue. Can you let me know a few things: 1. Are you modifying the keyword or any of the translations before attempting to delete the translation? 2. Are you able to delete a Keyword? a. From the Keywords screen click the delete icon in the "Action" column. b. From the Keyword screen. Select the keyword to delete and click the "Remove" button.

thanks Ben

Comment #11

Posted on Dec 15, 2009 by Massive Lion
  1. Are you modifying the keyword or any of the translations before attempting to delete the translation? No.

  2. Are you able to delete a Keyword? a. From the Keywords screen click the delete icon in the "Action" column. Yes, this works, but then the entire keyword is deleted and I just would like to delete one of the bundle occurences e.g. TDL

    b. From the Keyword screen. Select the keyword to delete and click the "Remove" This results in the following error:

An internal error has occured in the system. The action you were attempting cannot be recovered. Please inform your system administrator. org.hibernate.NonUniqueObjectException: a different object with the same identifier value was already associated with the session: [org.tonguetied.keywordmanagement.Keyword#2724] ...

Comment #12

Posted on Dec 17, 2009 by Happy Giraffe

Ok finally figured out how to replicate the problem. The problem only happens with IE. This is what I get for only testing with Firefox :) I still need to figure out why. Might be an IE setting.

Comment #13

Posted on Dec 17, 2009 by Happy Giraffe

Issue 88 has been merged into this issue.

Comment #14

Posted on Dec 17, 2009 by Happy Giraffe

The delete button on the keywords page uses an for the delete button. In IE, the value of the input image is never sent, hence the controller does not know how to process this request. See this link for more detailed description of the problem. http://www.singlebrook.com/node/111

The image input should be replaced with an anchor tag and href location should be the KeywordController.

Comment #15

Posted on Dec 17, 2009 by Massive Lion

Yes! I tested it in Firefox and then it works fine!! But it would of course be nice if it also works for IE

Rene

Comment #16

Posted on Dec 17, 2009 by Happy Giraffe

Coming in the next release :)

Status: Fixed

Labels:
Type-Defect Usability Component-UI Component-Persistence Priority-Medium Milestone-Release1.3.2 Browser-IE6 Browser-IE7 Browser-IE8