What steps will reproduce the problem?

Any relationship that includes a schema prefix in the table name.

class A < Sequel::Model(:schema__table_a) one_to_many :schema__table_b end

class B < Sequel::Model(:schema__table_b) end

A.first.bs will generate sql of the form: SELECT * FROM (SELECT * FROM "SCHEMA"."TABLE_A") WHERE ROWNUM <= 1 SELECT * FROM "SCHEMA"."TABLE_B" WHERE ("SCHEMA__TABLE_B"."SYSID" = 1)

The symbol reference :schema__table_b is not translated to the proper schema table name reference in the 2nd WHERE clause. See attached files.

What version of the product are you using? On what operating system?

sequel 2.7.1, os x 10.5.5, intel macbook pro

Please provide any additional information below.

patched the following at line 67 of sequel_core/adapter/oracle.rb (see attached file)

    when Sequel::SQL::QualifiedIdentifier
      # reformat '__' to "." in symbol names containing schema

references in subclauses

      literal(LiteralString.new(v.to_s(self).gsub(/__/, '"."')))

Your argument to one_to_many is wrong. Try

class A < Sequel::Model(:schema__table_a) one_to_many :bs end

class B < Sequel::Model(:schema__table_b) end

Try that first and report back whether or not that works.

Sorry, typo on my part. I abstracted the example from this actual code, which specifies the one_to_many argument correctly.

class Booking < Sequel::Model(:forward__booking) set_primary_key :sysid one_to_many :case_charges, :key => :sysid end

class CaseCharge < Sequel::Model(DB[:forward__case_charge]) set_primary_key :case_pk end

BTW, I applied the patch here and it works...

Looks like a definite bug in sequel, but your patch is not the correct way to fix it. This should fix it correctly:

diff --git a/lib/sequel_core/dataset/sql.rb b/lib/sequel_core/dataset/sql.rb index 23f1e3d..0a09f3c 100644 --- a/lib/sequel_core/dataset/sql.rb +++ b/lib/sequel_core/dataset/sql.rb @@ -558,7 +558,7 @@ module Sequel # SQL fragment for the qualifed identifier, specifying # a table and a column (or schema and table). def qualified_identifier_sql(qcr) - [qcr.table, qcr.column].map{|x| x.is_one_of?(SQL::QualifiedIdentifier, SQL::Identifier) ? literal(x) : quote_identifier(x)}.join('.') + [qcr.table, qcr.column].map{|x| x.is_one_of?(SQL::QualifiedIdentifier, SQL::Identifier, Symbol) ? literal(x) : quote_identifier(x)}.join('.') end

Please test it and report back whether it works. # Adds quoting to identifiers (columns and tables). If identifiers are not

That works. Thanks so much.

BTW, a couple of spec failures with the change. The expected output needs to be revised:

1) 'Symbol should be able to qualify an identifier' FAILED expected: "\"XYZ__ABC\".\"XYZ\"", got: "\"XYZ\".\"ABC\".\"XYZ\"" (using ==) ./spec/sequel_core/core_sql_spec.rb:279:

2) 'Symbol should be able to specify a schema.table.column' FAILED expected: "\"SCHEMA\".\"TABLE__NAME\".\"COLUMN\"", got: "\"SCHEMA\".\"TABLE\".\"NAME\".\"COLUMN\"" (using ==) ./spec/sequel_core/core_sql_spec.rb:283:

Yes, I noticed that and made some similar changes to the specs. I've committed them to my local repository but haven't pushed the changes yet.

Fixed: http://github.com/jeremyevans/sequel/commit/8f7b0a770d3d72d79b2233743679cf482ca86e3e