Export to GitHub

rainmeter - issue #111

Dragging skins to new locations is now broken...


Posted on Sep 26, 2009 by Quick Elephant

There is a new bug (Not sure which revision caused it, but I think it started sometime on or after 229) where when you move a skin by dragging, and for any reason the skin is refreshed / redrawn, either by a refresh from the context menu or by a measure or !bang causing a redraw automatically, the skin jumps back to the original position.

It seems to be that the write to WindowX and WindowY in Rainmeter.ini is one "refresh/redraw cycle" behind. If you move a skin, then move it again before the refresh/redraw, it will jump back to the location of the first "move".

I can sit with Rainmeter.ini open in a text editor and see that the WindowX and WindowY is not being updated properly when a skin is moved.

We must not make a public beta build until this is located and fixed.

Comment #1

Posted on Sep 26, 2009 by Quick Elephant

(No comment was entered for this change.)

Comment #2

Posted on Sep 26, 2009 by Quick Elephant

(No comment was entered for this change.)

Comment #3

Posted on Sep 26, 2009 by Quick Elephant

I believe the issue MIGHT be in r229 in MeterWindow.cpp at line 3283 where "m_Dragging = false;" was added.

Spx, could you look at this and see what you think?

Comment #4

Posted on Sep 26, 2009 by Quick Elephant

Removing this "m_Dragging = false;" line SEEMS to fix the issue, but I will leave it to you to see if I am correct and make whatever changes you think correct spx...

Comment #5

Posted on Sep 26, 2009 by Quick Elephant

Comment deleted

Comment #6

Posted on Sep 26, 2009 by Grumpy Bird

I can verify that this is not an issue in build r223 In the following environs: Vista 32bit Vista 64bit 7 RC1 64bit

Comment #7

Posted on Sep 26, 2009 by Helpful Camel

Comment deleted

Comment #8

Posted on Sep 26, 2009 by Helpful Camel

Sorry... Thank you for the verification. I understood, and removed it on r233.

Comment #9

Posted on Sep 26, 2009 by Grumpy Bird

No apologies necessary friend :)

Great work!

Comment #10

Posted on Sep 26, 2009 by Quick Elephant

(No comment was entered for this change.)

Comment #11

Posted on Jan 2, 2010 by Quick Rabbit

How can i fix it in ver 1.1?

Status: Fixed

Labels:
Type-Defect Priority-Critical Milestone-Release1.1 Component-UI Component-Logic Component-Skins