Export to GitHub

rainmeter - issue #108

Button Meter doesn't appear when DynamicVariables=1 is added.


Posted on Sep 5, 2009 by Quick Rhino

Button Meter doesn't appear when DynamicVariables=1 is added.

For instance,

[Hours] Measure=Time Format=%H

[Minutes] Measure=Time Format=%M

[MeterTest] Meter=Button X=0 Y=0 ButtonImage=button.png ButtonCommand=!Execute ["http://www.google.com/search?&q=[Hours]:[Minutes]"]

DynamicVariables=1

Environment: Rainmeter.exe v1.1 r213 32bit Windows XP SP3

Comment #1

Posted on Sep 6, 2009 by Helpful Camel

This happens because meter's dimension are reset to 1. Therefore, it is necessary to set the dimension again when Dynamic Variables is enabled.

MeterImage with the same issue fixed. (attach the files of MeterImage)

Attachments

Comment #2

Posted on Sep 7, 2009 by Quick Elephant

Since I don't know for sure which revision you used to create this full version of MeterImage.cpp, could I get you to download the latest revision, make this change and use Tortoise to create a "patch" of the change? Then I can get it in the trunk for you without danger of a version conflict. I have stepped on Rainy once and am determined not to do it again.. ;-)

Comment #3

Posted on Sep 7, 2009 by Helpful Camel

"MeterImage.patch" in MeterImage.zip is based on r214. I think maybe it's okay. ;-)

If possible, could I participate in the team as a developer? I think that maybe I can contribute several bug fixes though I am not good at English. :)

Comment #4

Posted on Sep 7, 2009 by Quick Elephant

Thanks! I will get your change in today.

As to the other question, that would be up to Rainy. He reads these issue messages, so I'm sure he will reply when he gets time.

Comment #5

Posted on Sep 7, 2009 by Quick Rhino

Thank you so much spx268. BTW, to solve this issue, If it is possible, could you apply this bug fix also to the Button meter?

About the matter to join in to the dev team, I will call the project owner from me later.

Comment #6

Posted on Sep 7, 2009 by Helpful Camel

It's possible. Meters that have the same issue was fixed.

Includes: MeterBar, MeterBitmap, MeterButton, MeterRotator

Attachments

Comment #7

Posted on Sep 7, 2009 by Quick Elephant

Added...

Comment #8

Posted on Sep 8, 2009 by Quick Rhino

Thanks again, spx268.

Now, I actually tested. It seems to find trouble still a little bit though there is no problem in the first sample Config.↑ For instance, it seems not to work normally for skin that shows the button when the mouse is put on a certain area. This is a problem of relating to Update perhaps, and the button shows strange behavior. Since I attached a sample, I would like you to verify it.

Attachments

Comment #9

Posted on Sep 8, 2009 by Helpful Camel

Comment deleted

Comment #10

Posted on Sep 8, 2009 by Helpful Camel

You guessed right. "Hidden=1" is forcedly applied when the meters are updated every time. Similarly, I seem that MoveMeter, Enable/DisableMeasure etc. are ignored too.

I think that dynamic variables have a lot of potential bugs (or specifications), and it's necessary to discuss it to define about behavior.

E.g. Which is given priority to:

[MeterMenu] MouseOverAction=!Execute [!RainMeterHideMeter MeterButton1] MouseLeaveAction=!Execute [!RainmeterShowMeter MeterButton1]

[MeterButton1] DynamicVariables=1

Hidden=[MeasureButton1]

Comment #11

Posted on Sep 9, 2009 by Quick Rhino

I agreed. I also have the anxiety that "dynamic variables" causes many other problems. And I'm sure that since we cannot overcome these issues, the "dynamic variables" is not real ENHANCEMENT of Rainmeter. To clear the issue, I will verify it more in detail in various tests. And I hope that you cooperate with this issue continuously. Thanks,

Comment #12

Posted on Jun 2, 2010 by Quick Rhino

(No comment was entered for this change.)

Status: Fixed

Labels:
Type-Defect Priority-Medium