Export to GitHub

openjpeg - issue #67

openjpeg.pc.cmake rewrites wrong variables


Posted on Mar 30, 2011 by Happy Hippo

With the cmake patch that is now included libopenjpeg.pc.cmake contains wrong variables.

Since we in Gentoo use 1.4 I provide this patch based on libopenjpeg.pc.in.

Best might be just revert your pkgconfig patch that is now in trunk and apply this one.

Attachments

Comment #1

Posted on Mar 30, 2011 by Grumpy Dog

This should already be fixed per, http://code.google.com/p/openjpeg/source/detail?spec=svn742&r=708

Comment #2

Posted on Mar 30, 2011 by Grumpy Dog

(No comment was entered for this change.)

Comment #3

Posted on Mar 30, 2011 by Happy Hippo

Ahem, as i said that one IS broken. Thats why i said it should be reverted and this one applied

Comment #4

Posted on Mar 30, 2011 by Grumpy Dog

OK, please detail how it is broken? It worked as-is when I commited it, unless something's changed elsewhere in the meantime.

Comment #5

Posted on Mar 30, 2011 by Grumpy Dog

Looking things over, your version * drops libopenjpeg1.pc and the libopenjpeg.pc symlink to it, replaced by a single libopenjpeg.pc * prefixes some variables with ${prefix}, which looks wrong to me too.

??

Comment #6

Posted on Mar 30, 2011 by Grumpy Dog

ah, I see -L being wrong, I can at least fix that.

Comment #7

Posted on Mar 30, 2011 by Grumpy Dog

I see a lot more fail now, I'll fix it close to what you provided, thanks!

Comment #8

Posted on Mar 30, 2011 by Grumpy Dog

http://code.google.com/p/openjpeg/source/detail?r=743

Comment #9

Posted on Mar 30, 2011 by Happy Hippo

Now it is really fixed. Thanks (sorry i was not responsive i was going home from work)

It depends that prefix is optional i just preffer it stated :)

Status: Fixed

Labels:
Type-Defect Priority-Medium