Export to GitHub

openjpeg - issue #15

pi.c copy paste mistakes ?


Posted on Feb 25, 2010 by Massive Elephant

Hi everybody,

I'm not sure of that but I detected what I believe to be little mistakes in pi.c source file (http://code.google.com/p/openjpeg/source/browse/trunk/libopenjpeg/pi.c) :

at line 212: if (!((pi->y % (comp->dy << rpy) == 0) || ((pi->y == pi->ty0) && ((try0 << levelno) % (1 << rpx))))){

shouldn't rpx be rpy at the end of the line ?

line 219: if ((res->pw==0)||(res->pw==0)) continue;

res->pw twice ? I think it should be if ((res->pw==0)||(res->ph==0)) ..

the same mistakes (if they are mistakes) are reproduced at lines : 293, 300, 372 and 379

thanks

Comment #1

Posted on Apr 8, 2010 by Grumpy Camel

Thanks for catching this amazing bug ! I fixed the code (rev 561 and 562).

Status: Fixed

Labels:
Type-Defect Priority-Medium