Export to GitHub

oauthconsumer - issue #2

Some sub-delims aren't URLEncoded in OAuth Parameters

Posted on Jun 6, 2008 by Swift Bear

What steps will reproduce the problem? - Send an OAuth request that has a parameter with a RFC 3986 sub-delim in it (for example, '!').

What is the expected output? What do you see instead? - Sub-delim should be escaped in SignatureBaseString, but it's not. Simple fix is to add all sub-delims to the list of characters to encode in NSString+URLEncoding.m encodeURLParameterString: on line 44. The list of sub-delims is available at http://tools.ietf.org/html/rfc3986#section-2.2. I'm using CFSTR(":/=,!$&'()*+;[]@#?").

Comment #1

Posted on Jul 22, 2008 by Happy Rhino

(No comment was entered for this change.)

Comment #2

Posted on Oct 7, 2008 by Happy Rhino

Patch committed. Thanks, Mike!

Status: Fixed

Labels:
Type-Defect Priority-Medium