
nurpawiki - issue #13
Clean up task action handlers -- use 3 actions instead of one combined action for task side effects
Re this change:
Author: jjhellst Date: Wed Nov 28 15:04:00 2007 New Revision: 75
Modified: trunk/nurpawiki.ml
Log: Use coservices and actions instead of service page parameters to up/down task priorites and complete tasks. The actions take care of side-effecting DB with the requested task changes.
Apply Vincent's comments: > ok, You use one action only with two parameters. You could have done three > different actions. Thus, no need of > + | _ -> assert false > which is not really clean (what if the user change the name of the action?)
or alternatively have one action for task comple and one action for up/down priority with a bool parameter to specify direction. This might actually make the code shorter and reduces error handling code.
Janne
Comment #1
Posted on Dec 2, 2007 by Happy Lion(No comment was entered for this change.)
Comment #2
Posted on Dec 2, 2007 by Happy LionFixed in r80.
Status: Fixed
Labels:
Type-Enhancement
Priority-Medium
Maintainability