Export to GitHub

mtg-familiar - issue #38

Price lookup / gatherer page fail for split cards


Posted on Oct 17, 2011 by Happy Horse

What steps will reproduce the problem? 1. Search for Punishment (as in Crime/Punishment) 2. Try to fetch the price 3. Try to go to the Gatherer page

What is the expected output? What do you see instead? The price returns "No Internet Connection" and the Gatherer page is the homepage

I think this will involve a db update. My gut tells me the multiverseID isn't getting set correctly for split cards. Unsure about the price. It appears to be implemented incorrectly on magiccards.info too

Comment #2

Posted on Oct 17, 2011 by Massive Bear

Also, it's linking to: http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=0

When it should be linking to: http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=107285

Or more specifically: http://gatherer.wizards.com/Pages/Card/Details.aspx?part=Crime&multiverseid=107285 http://gatherer.wizards.com/Pages/Card/Details.aspx?part=Punishment&multiverseid=107285

Also, if it's any consolation, MTG Tracker is 100% completely broken in the same regards. :)

Comment #3

Posted on Oct 17, 2011 by Happy Horse

multiverseid is an easy fix, TCG lookups are trickier because I treat split cards as two separate cards. I'll handle this.

And never let complacency in rivals be consolation. I don't want to be better than them, I want to be the best ever!

Comment #4

Posted on Nov 23, 2011 by Happy Horse

Gatherer lookup no longer fails

Comment #5

Posted on Jun 7, 2012 by Happy Horse

Finally fixed.

Comment #6

Posted on Aug 16, 2012 by Happy Horse

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Defect Priority-High