Export to GitHub

mtg-familiar - issue #188

Screen lock not locking


Posted on May 12, 2014 by Swift Ox

What steps will reproduce the problem? 1.rewriting code to allow screen lock 2. 3.

What is the expected output? What do you see instead? I leave the life counter on awaiting further input, but it locks the screen, even with the option checked in settings and Smart Stay on my S-2

What version of the product are you using? On what operating system? Galaxy S-2

Please provide any additional information below. Not important, but liked buttons in card search better than swipe.

Comment #1

Posted on May 15, 2014 by Happy Horse

The app follows "Keep the Screen On" from http://developer.android.com/training/scheduling/wakelock.html. Previously it had followed "Keep the CPU On," which was battery inefficient.

I've created a test APK to check this kind of thing. You can download it here: https://drive.google.com/file/d/0B31NGyvnZTzWYkMwaGpwcnlBUWV5dWE1OXJaWVpZbFdZbHhR/edit?usp=sharing It has "Keep the Screen On" enabled, and also tests brightness adjustment. If the screen turns off in the test app after a timeout, then your phone isn't following Android specifications, and I can't do much about that.

Comment #2

Posted on May 16, 2014 by Swift Ox

I installed the brightnessTest app, but it only has a slider for the phone's brightness, a readout for said brightness and a tick box for default brightness. Where was the "Keep the Screen On" you mentioned?

Comment #3

Posted on May 18, 2014 by Happy Horse

That app will keep the screen on by default, there isn't a checkbox for it. You should notice that bringing the brightness slider to 0% turns off the screen. This is unexpected and incorrect behavior. 3.0.2 (released yesterday) should fix the issue.

Comment #4

Posted on May 18, 2014 by Happy Horse

(No comment was entered for this change.)

Comment #5

Posted on May 18, 2014 by Swift Ox

I used the brightnessTest, waited a few minutes past the usual screen lock setting (1 min) and it remained on. Would this new brightnessTest make a difference? if so, can I just get it from the same place as last time?

Comment #6

Posted on May 21, 2014 by Happy Horse

BrightnessTest was just a test to see how certain phones behave, since my phone wouldn't turn off as yours did. The issue is fixed in the latest build, 3.0.2

Comment #7

Posted on May 21, 2014 by Swift Ox

Where can I get 3.0.2?

Comment #8

Posted on May 25, 2014 by Happy Horse

https://play.google.com/store/apps/details?id=com.gelakinetic.mtgfam

Status: Verified

Labels:
Type-Defect Priority-Medium