Export to GitHub

mtg-familiar - issue #172

Gatherings should have default display modes.


Posted on Jun 19, 2013 by Quick Rabbit

What steps will reproduce the problem? 1. Start with the life counter in the Normal display mode. 2. Switch to a gathering for your EDH group. 3. Be forced to manually change to Commander mode.

What is the expected output? What do you see instead?

I believe the life counter gatherings should be able to have default display modes set when they are created. This way One can create EDH gatherings or multiplayer gatherings that default to Commander or Compact modes without having to switch them manually. This doesn't currently happen.

What version of the product are you using? On what operating system?

Latest subversion checkout.

Please provide any additional information below.

I've attached a patch file that applies changes that implement this behavior. I've added a new helper Gathering class that encapsulates the player list and display mode and added a new layout called gathering_set_display_mode_row.xml for an additional row in the GatheringCreateFragment fragment.

This patch was mostly just the result of exploring the MTGFamiliar source. I decided to share it because it is a feature I would like to see.

Attachments

Comment #1

Posted on Jun 20, 2013 by Happy Horse

And it is a feature you will see. I applied the patch, and then made a few changes myself, like making the display mode row permanent, changing the dialog to a spinner, and cleaning up some warnings. It's in R815. Let me know what you think.

Comment #2

Posted on Jun 20, 2013 by Quick Rabbit

Looks great, thanks. Sorry about the terrible UI code I threw in there, I just kinda took a stab in the dark there. One really minor thing I just noticed though was that the title "Display Mode" capitalizes the second word while "Starting life" doesn't.

Comment #3

Posted on Jun 21, 2013 by Happy Horse

Good catch. Fixed the capitalization and closing the ticket.

Status: Verified

Labels:
Type-Defect Priority-Medium