Export to GitHub

mp4v2 - issue #143

mingw build issue


Posted on Oct 29, 2012 by Happy Hippo

Build failure on mingw. Tried with mingw-w64 cross compilation from Linux host, but others will be more or less the same. Patch is attached.

1) libplatform/platform_win32.cpp is missing from GNUmakefile.am

2) In platform.h, currently mingw goes along the same path as MSVC and requires proper definition of MP4V2_EXPORTS or MP4V2_USE_STATIC_LIB so that MP4V2_EXPORT macro is properly evaluated to declspec(). However, currently none of symbols are provided via configure/makefile. As a result, MP4V2_EXPORT is always evaluated to __declspec(dllimport), and results in build error. In the patch, I simply fixed this condition so that mingw goes to the same path as other GCC environments. Since mingw gcc (version 4) happily accepts __atribute((visibility("default"))), no need to use MSVC way.

3) By the previous fix, mingw DLL compilation can now be enabled. So, I fixed configure.ac to enable it.

Attachments

Comment #1

Posted on Oct 29, 2012 by Happy Lion

Thanks! I have a bit of a backlog going on, so I'll get this as soon as I can.

Comment #2

Posted on Dec 28, 2012 by Happy Lion

If I add commit rights, could you apply this patch? I'm super swamped at work/in life, but I agree this should be applied. Let me know if that's okay with you.

Comment #3

Posted on Dec 29, 2012 by Happy Hippo

Well, to tell the truth, I hesitate to touch official repo (I'm not familiar with subversion). However, if you want to me do so, I will try it. Setting up svn client is not problem at all (it's a simple matter of apt-get or something), and maybe I can use git-svn (actually I'm using it for my private copy of mp4v2).

Status: Accepted

Labels:
Type-Defect Priority-Medium