Export to GitHub

libkate - issue #4

[PATCH] Fix build on Cygwin/Win32


Posted on Sep 16, 2008 by Happy Bear

On Win32 platforms (Cygwin and MinGW), libtool requires the -no-undefined flag in order to create a shared library. The libkate-0.1.12 Makefile.am has a second hyphen before this flag, causing libtool to ignore it.

I'm attaching a patch to fix this, which can be attributed to the Cygwin Ports project.

Attachments

Comment #1

Posted on Sep 22, 2008 by Massive Rabbit

Thanks, will apply. Why did you remove -lc though ? I think it's fairly useless, but also harmless (this was a leftover from attempts at fixing odd link problems with some libc routine so I'll remove it anyway)

Comment #2

Posted on Sep 22, 2008 by Happy Bear

Because libtool determines whether and how to link libc.

Comment #3

Posted on Sep 29, 2008 by Massive Rabbit

applied in 0.2.1, thanks

Status: Fixed

Labels:
Type-Defect Priority-Medium