What steps will reproduce the problem? 1. Install the add-on 2. Restart Firefox
Simply starting Firefox with v0.66 of the add-on causes huge memory issues. Firefox will claim all remaining physical memory. Here is the output of 'top' every 3 seconds for the first 40 seconds to demonstrate this:
PID PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 2957 20 0 1945m 351m 38m R 101 8.9 5:27.65 firefox-bin 2957 20 0 7363m 449m 39m R 98 11.4 5:30.61 firefox-bin 2957 20 0 7947m 487m 38m S 98 12.3 5:33.55 firefox-bin 2957 20 0 30.7g 681m 38m S 103 17.2 5:36.66 firefox-bin 2957 20 0 60.7g 943m 38m S 104 23.8 5:39.78 firefox-bin 2957 20 0 88.4g 1.2g 38m R 104 30.0 5:42.90 firefox-bin 2957 20 0 113g 1.4g 38m S 103 35.7 5:46.00 firefox-bin 2957 20 0 136g 1.6g 38m R 103 40.9 5:49.11 firefox-bin 2957 20 0 157g 1.8g 38m S 103 45.6 5:52.21 firefox-bin 2957 20 0 177g 1.9g 38m R 103 50.2 5:55.32 firefox-bin 2957 20 0 195g 2.1g 38m R 101 54.4 5:58.38 firefox-bin 2957 20 0 213g 2.3g 38m S 100 58.5 6:01.39 firefox-bin 2957 20 0 229g 2.4g 36m S 98 62.3 6:04.36 firefox-bin 2957 20 0 245g 2.5g 31m S 96 65.6 6:07.25 firefox-bin
After this, the amount of memory used by Firefox remained the same.
Whereas by contrast, without the addon firefox operates as follows:
PID PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 2957 20 0 1166m 427m 40m S 1 10.8 7:01.41 firefox-bin
What version of the product are you using? On what operating system? I am using v0.66 on Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 ID:20110429090038. This is running on Ubuntu 10.10
This issue doesn't appear to be present in the current stable release, v0.51
Comment #1
Posted on May 25, 2011 by Swift OxComment deleted
Comment #2
Posted on May 25, 2011 by Swift OxConfirmed in Ubuntu 10.10 x64. Issue does not appear in Ubuntu 11.04 x86 or Fedora 15 x64.
Firefox Error Console logs message "Too Much Recursion"... I'm pulling the download from Mozilla, and marking 0.66 as dev build (noting the incompatibility). Oddly, Fedora x64 doesn't seem affected at all.. Here are it's 'top' results:
0.51:
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
1851 owner 20 0 796m 103m 33m S 2.0 10.3 0:04.65 xulrunner-bin
1851 owner 20 0 670m 86m 31m R 31.6 8.7 0:05.60 xulrunner-bin
1851 owner 20 0 705m 99m 33m S 13.0 9.9 0:05.99 xulrunner-bin
1851 owner 20 0 706m 99m 33m S 0.3 9.9 0:06.00 xulrunner-bin
1851 owner 20 0 706m 99m 33m S 0.7 10.0 0:06.02 xulrunner-bin
1851 owner 20 0 711m 102m 33m S 0.7 10.2 0:06.04 xulrunner-bin
0.61:
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
1703 owner 20 0 813m 108m 34m S 5.9 10.8 0:09.66 xulrunner-bin
1703 owner 20 0 705m 97m 32m S 41.3 9.8 0:10.90 xulrunner-bin
1703 owner 20 0 705m 98m 32m S 0.3 9.8 0:10.91 xulrunner-bin
1703 owner 20 0 705m 98m 32m S 0.3 9.8 0:10.92 xulrunner-bin
1703 owner 20 0 705m 98m 32m S 0.3 9.9 0:10.93 xulrunner-bin
1703 owner 20 0 710m 99m 32m S 0.7 9.9 0:10.95 xulrunner-bin
1703 owner 20 0 710m 100m 32m S 0.3 10.0 0:10.96 xulrunner-bin
The issue seems to be in the preference change observer. Working on a fix and I'll update when I have more info. Thank you for reporting this.
Comment #3
Posted on May 25, 2011 by Swift OxIssue is resolved. Making a couple minor bug fixes, then I should have the fixed version up by tomorrow. Thanks again for reporting this.
Comment #4
Posted on May 26, 2011 by Swift OxHere is the fixed version: https://code.google.com/p/https-finder/downloads/detail?name=httpsfinder067RC.xpi (diff here: https://code.google.com/p/https-finder/source/diff?spec=svn110&r=110&format=side&path=/trunk/src/content/browserOverlay.js).
The fix works for me - but let me know if you're still having problems. For some reason it appears that preference change observers are handled differently in Firefox x64 vs x86 - though I don't understand why Fedora vs Ubuntu would act differently in this manner...
Marking issue fixed for now. I will resubmit to Mozilla in a day or two. If you still have problems with it, let me know and I will reopen the ticket.
Status: Fixed
Labels:
Type-Defect
Priority-Critical