Export to GitHub

httplib2 - issue #244

Crash depending on cache name and url


Posted on Jan 24, 2013 by Swift Monkey

What steps will reproduce the problem? http = httplib2.Http("foobar") http.request("https://api.facebook.com/method/fql.query?format=json&query=SELECT+total_count+FROM+link_stat+WHERE+url%3D%22http%3A%2F%2Ffin.foobar.com%2Fuutiset%2Fartikkeli.cfm%2F2011%2F08%2F20%2Ffacebookin_tykkaa-painike_saksan_lakia%22")

What is the expected output? What do you see instead? Response, but instead: File "init.py", line 1272, in request (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey) File "init.py", line 1084, in _request _updateCache(headers, response, content, self.cache, cachekey) File "init.py", line 397, in _updateCache cache.set(cachekey, text) File "init.py", line 687, in set f = open(cacheFullPath, "wb") FileNotFoundError: [Errno 2] No such file or directory: 'foobar\api.facebook.com,method,fql.query,format=json&query=SELECT+total_count+FROM+link_stat+WHERE+url%3D%22http%3A%2F%2Ffin.foobar.com%2Fuutiset%2Fartikkeli.cfm%2F2011%2F08%2F2 0%2Ffacebookin_tykkaa-painike_,6a66abb64877560a53008cb0f7ffd354'

What version of the product are you using? On what operating system? Windows XP with Python 3.3 and httplib2 0.7.7.

Please provide any additional information below. No problems if no cache is used or the name of cache is shorter like "foo".

Attachments

Comment #1

Posted on Mar 7, 2013 by Massive Hippo

You should probably provide a different implementation of 'safe':

http://httplib2.googlecode.com/hg/doc/html/libhttplib2.html#httplib2.FileCache

Status: Closed

Labels:
Type-Defect Priority-Medium