Export to GitHub

harviewer - issue #64

Single-page waterfalls aren't expanded in the preview


Posted on Sep 12, 2011 by Happy Bear

What steps will reproduce the problem?

I created an example at http://www.brianp.net/demo/waterfall7/

What is the expected output? What do you see instead?

I thought the waterfall would be expanded automatically, based on
this code in webapp/scripts/preview/pageList.js:

        // Expand appended page by default, only if there is only one page
        // Note that there can be more page-lists (pageTable elements)
        var len1 = table.firstChild.childNodes.length;
        var len2 = table.parentNode.childNodes.length;
        if (len1 == 1 && len2 == 1)
            this.toggleRow(table.firstChild.firstChild);

However, the waterfall isn't expanded. I have to click the "+" button to expand it.

What version of the product are you using? On what operating system?

harviewer 2.0.14

Please provide any additional information below.

The "len2==1" condition in that code fails because len2 is 2. I think
that's because the HarPreview initialization code creates a div (to hold
a top-level menu) before it creates the table.

It works (i.e., the waterfall is expanded) if I change that line of pageList.js to this:
        if (len1 == 1 && len2 == 2)

Comment #1

Posted on Sep 13, 2011 by Massive Wombat

(No comment was entered for this change.)

Comment #2

Posted on Sep 18, 2011 by Massive Wombat

Patch committed at R392

Test at R393

Honza

Comment #3

Posted on Nov 13, 2011 by Massive Wombat

This issue is fixed in HAR Viewer 2.0.15 http://www.softwareishard.com/har/viewer/

Please let me know if it works for you.

Thanks! Honza

Status: Fixed

Labels:
Type-Defect Priority-Medium