Export to GitHub

fbterm - issue #7

32bpp and 16bpp modes don't look good on radeonfb


Posted on Dec 14, 2008 by Happy Camel

The fbterm on 32bpp radeonfb looks like in the attched screenshot.

Attachments

Comment #1

Posted on Dec 15, 2008 by Happy Horse

Comment deleted

Comment #2

Posted on Dec 15, 2008 by Happy Horse

for 32bpp, try to replace line 454-456 of src/screen.cpp

color = (red >> (8 - vinfo.red.length) << vinfo.red.offset) | (green >> (8 - vinfo.green.length) << vinfo.green.offset) | (blue >> (8 - vinfo.blue.length) << vinfo.blue.offset);

with

color = ((red << 16) | (green << 8) | blue);

if you still get the same result, then try

 color = ((red << 8) | (green << 16) | blue);

then color = (red | (green << 8) | (blue << 16)); ... and so on.

Comment #3

Posted on Dec 15, 2008 by Happy Camel

ATI cards use DIRECTCOLOR. Here is a patch based on mplayer's vo_fbdev2.c It works for me. I tested it on aty128fb and radeonfb.

Attachments

Comment #4

Posted on Dec 17, 2008 by Happy Horse

Thanks for your patch!

I made a little change on it, please help me test it.

Attachments

Comment #5

Posted on Dec 29, 2008 by Happy Horse

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Defect Priority-Medium