Export to GitHub

dotnetopenid - issue #182

NullReferenceException in Yadis.XrdElement.searchForServiceTypeUris()


Posted on Jan 7, 2009 by Swift Camel

latest dotnetopenid, with AOL hotfix.

when using OpenID:

dbrweb.co.uk

(only one example I know if)

this user experiences:

System.NullReferenceException: Object reference not set to an instance of an object. at DotNetOpenId.Yadis.XrdElement.searchForServiceTypeUris(Func2 p) at DotNetOpenId.Yadis.XrdsDocument.<findOPIdentifierServices>d__2f.MoveNext() at DotNetOpenId.Yadis.XrdsDocument.<generateOPIdentifierServiceEndpoints>d__a.MoveNext() at System.Collections.Generic.List1.InsertRange(Int32 index, IEnumerable1 collection) at System.Collections.Generic.List1.AddRange(IEnumerable`1 collection) at DotNetOpenId.Yadis.XrdsDocument.CreateServiceEndpoints(UriIdentifier claimedIdentifier) at DotNetOpenId.UriIdentifier.Discover() at DotNetOpenId.RelyingParty.AuthenticationRequest.Create(Identifier userSuppliedIdentifier, OpenIdRelyingParty relyingParty, Realm realm, Uri returnToUrl) at DotNetOpenId.RelyingParty.OpenIdRelyingParty.CreateRequest(Identifier userSuppliedIdentifier, Realm realm, Uri returnToUrl) at StackOverflow.Controllers.UsersController.RedirectToOpenIDProvider(OpenIdRelyingParty openid)

Comment #1

Posted on Jan 7, 2009 by Quick Panda

Of course the NullReferenceException itself is a bug, but more interesting is that this particular OpenID demonstrated that an OP returns the XRDS document at the Yadis location only if the Accept-Types HTTP header is set to the XRDS type. Fixing this resolved the issue.

This fix will get checked into the 2.5 branch.

Comment #2

Posted on Jan 7, 2009 by Quick Panda

Fixed in two part commits 3ab85f11d69a3059cebac203f77a05fe083d7b65 (branch v2.3) 7fb2d79d903590755ef1005ed28c525a8e1e4f73 (branch v2.5)

The commit v2.3 will need to be merged into v2.5 before v2.5 is fully fixed.

Comment #3

Posted on Jan 7, 2009 by Quick Panda

(No comment was entered for this change.)

Comment #4

Posted on Jan 7, 2009 by Swift Camel

excellent! Is this checked in and fixed in the latest binaries on top of the AOL fix? If so I'd like to deploy it so Technorati users can log in again..

Comment #5

Posted on Jan 7, 2009 by Quick Panda

Yes, this shipped with v2.5.2, and that release included the AOL hotfix.

Status: Fixed

Labels:
Type-Defect Priority-Medium Release-2.5