Export to GitHub

django-openid - issue #15

PATCH - silence warnings about deprecated max_length spelling with latest django


Posted on Mar 24, 2008 by Grumpy Ox

What steps will reproduce the problem? 1. Run python manage.py sql project name on a project using django-openid models.py

What is the expected output? What do you see instead?

There should be no warnings, but there are warnings if you are using the latest django from svn because the maxlength attribute in models.py is now max_length.

What version of the product are you using? On what operating system?

Latest from svn of both django and django-openid as of today. MacOS X.

PATCH :

$ svn diff

Index: models.py

--- models.py (revision 22) +++ models.py (working copy) @@ -1,17 +1,17 @@ from django.db import models

class Nonce(models.Model): - nonce = models.CharField(maxlength=8) + nonce = models.CharField(max_length=8) expires = models.IntegerField() def str(self): return "Nonce: %s" % self.nonce

class Association(models.Model): - server_url = models.TextField(maxlength=2047) - handle = models.CharField(maxlength=255) - secret = models.TextField(maxlength=255) # Stored base64 encoded + server_url = models.TextField(max_length=2047) + handle = models.CharField(max_length=255) + secret = models.TextField(max_length=255) # Stored base64 encoded issued = models.IntegerField() lifetime = models.IntegerField() - assoc_type = models.TextField(maxlength=64) + assoc_type = models.TextField(max_length=64) def str(self): return "Association: %s, %s" % (self.server_url, self.handle)

Attachments

Comment #1

Posted on Jun 26, 2009 by Quick Camel

Now, crash with the final version - 1.0.2

Status: New

Labels:
Type-Defect Priority-Medium