Export to GitHub

boblight - issue #10

Patch to support KarateLight devices


Posted on Dec 10, 2010 by Happy Bird

Hi,

since I could not find another way to send in a patch, I am using the Tracker :)

Attached is a patch that adds support for 'KarateLight' devices. It is a 8 (or with extension-pcb 16Channels) RGB-Dimmer. Schematics and Firmware can be found here: http://ca.rstenpresser.de/~cpresser/data/karate/

Without the patch the prefix and color data were send in two messages. Since Karatelight expects this to be just one message, I have changed the code to always send the prefix and color-data in one burst. This should not break other devices. At least, the AtmoLight device still works fine with the patch applied.

Greetings Carsten

Attachments

Comment #1

Posted on Dec 10, 2010 by Quick Cat

Nice, but why the change of putting the prefix in the buffer?

Comment #2

Posted on Dec 10, 2010 by Happy Bird

The Firmware has no state-maschine working the serial input. So the whole input needs to be processed at once.

I could change the KarateLight firmware, but I dont see a particular reason why one sould send the prefix and the data in two bursts. So I changed the boblightd code :)

Comment #3

Posted on Dec 10, 2010 by Quick Cat

I've added the first part of the patch in r333.

Comment #4

Posted on Dec 10, 2010 by Quick Cat

I agree that this is a nice optim, but it won't guarantee that the data gets sent in one burst.

Comment #5

Posted on Dec 10, 2010 by Helpful Hippo

Please use whichever is most robust for enduser!

Comment #6

Posted on Dec 10, 2010 by Quick Cat

Fixed in r337. Now someone just needs to test it I suppose.

Comment #7

Posted on Dec 11, 2010 by Quick Cat

(No comment was entered for this change.)

Comment #8

Posted on Jul 2, 2011 by Quick Cat

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement Priority-Medium