Export to GitHub

ardupirates - issue #11

Suggest single point for user-configurable variables


Posted on Jan 21, 2011 by Quick Bird

Since setting up the code can be very confusing to newbies and pro's alike, I suggest we move all user-configurable settings towards the ArduUser.h. I don't think the main .pde should be the place where users should edit settings that are unique to their multirotor, location or person.

Moving all these settings towards ArduUser.h also prevents the situation where new code is released and several files have to be manually merged because of new code and user-specific changes are conflicting.

In such manner, it's also easier to just try or test several code release sequentially without having to edit multiple files each time. Improves usability and maintainability.

Comment #1

Posted on Jan 21, 2011 by Quick Bird

(No comment was entered for this change.)

Comment #2

Posted on Jan 21, 2011 by Happy Horse

If it's not a big deal, we should separate the config.file from the main code. That would also make it easier for the Online Configurator. And much easier for noobs! ;)

Comment #3

Posted on Jan 21, 2011 by Quick Bird

Agreed, good point !

Comment #4

Posted on Jan 21, 2011 by Grumpy Elephant

Absolutly agreed, I'm waiting on Hein's reply, as I have made a list of all defines that should be in the online config, and could be placed in the arduser.h or other single .h

Dani

Comment #5

Posted on Jan 22, 2011 by Quick Bird

Hein, Would you allow me to take your latest (r255) and move all user settings into ArduUser.h ? Should we give the file a more obvious name like for instance config.h ?

Comment #6

Posted on Jan 22, 2011 by Quick Bird

I just committed these proposed changes in r256, but I accidentally did so in Hein's branch. I'm so sorry, Hein, please forgive me - it won't happen again ! Can someone tell me how I can get the files I have here locally into my own branch (Kim) without f*ck!ng up someone else's work ?

Thanks !

Comment #7

Posted on Jan 23, 2011 by Quick Bird

Could you guys please take a look at r256 and comment ? Thanks !

Comment #8

Posted on Jan 23, 2011 by Swift Rhino

Hi Kidogofoto,

I moved your changes to your folder "Kim". Please update the ArduPiratesNG under the Trunk directly. This will be the version that all of the developers combine their work. Thanx for changes. Please update it under trunk....

Greetings, Hein

Comment #9

Posted on Jan 23, 2011 by Happy Dog

I have tested your config file. Everything works. There are a few changes though that I can make on the descriptions that are not clear for you. If you are OK with them, I think it is time to upload to the trunk. It will make life muche easier for everybody. Also we should arrange to get it in the global configurator as Kinderkram suggested. I think it is very much complete at the moment. Emile

Comment #10

Posted on Jan 24, 2011 by Quick Bird

Go ahead Emile, and thanks for your help ! ;)

Comment #11

Posted on Jan 24, 2011 by Quick Bird

It is now in the trunk; I suggest we test and then close this issue.

Comment #12

Posted on Jan 26, 2011 by Quick Bird

Seems to go well. I'm closing this one.

Status: Fixed

Labels:
Type-Enhancement Priority-High