Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level editor view movement #187

Closed
raptor opened this issue Aug 22, 2015 · 2 comments
Closed

Level editor view movement #187

raptor opened this issue Aug 22, 2015 · 2 comments

Comments

@raptor
Copy link
Contributor

raptor commented Aug 22, 2015

From Jomskylark on December 19, 2012 19:12:05

Moving the level editor's viewpoint diagonally via WASD is only possible if W (up) or S (down) is pressed, THEN the left/right key. However, pressing A (left) or D (right) BEFORE W or S negates the up/down movement.

Not a big deal but it makes the level editor movement feel "glitchy."

Original issue: http://code.google.com/p/bitfighter/issues/detail?id=187

@raptor
Copy link
Contributor Author

raptor commented Aug 22, 2015

From buckyballreaction on December 24, 2012 10:18:00

watusimoto, this is because we're testing for input strings instead of input codes in EditorUserInterface::onKeyDown(). When pressing 'A' + 'S', the inputString returned is just 'A' (see diagnostics).

The solution is to test for input codes again. What was the reason for moving to input strings in the first place? I don't remember..

@raptor
Copy link
Contributor Author

raptor commented Aug 22, 2015

From watusim...@bitfighter.org on December 30, 2012 03:21:03

Correct diagnosis, but wrong solution, as raw input codes cannot differentiate between Up and Shift+Up (for example). The solution I implemented looks at what keys you've most recently pressed, and selects that one if more than one key is pressed. Previously, we focused on an arbitrary key.

Checkin 6313 fixes this issue.

Status: Fixed

@raptor raptor closed this as completed Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant