Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boost dependency #205

Closed
GoogleCodeExporter opened this issue Mar 30, 2015 · 3 comments
Closed

Remove boost dependency #205

GoogleCodeExporter opened this issue Mar 30, 2015 · 3 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

Make boost a hard dependency only for shared_ptr is a bad idea. Please use 
std::tr1::shared_ptr as default. And make the use of boost optional. I try to 
avoid boost as much as possible, and others do too.

Original issue reported on code.google.com by p...@geromueller.de on 21 May 2013 at 1:52
@GoogleCodeExporter
Copy link
Author 

shared_ptr isn't the only reason for using boost - yaml-cpp also uses 
Boost.Iterator. I couldn't find a standard implementation of that, but it's 
possible I missed it - do you know of one?

Original comment by jbe...@gmail.com on 1 Jun 2013 at 8:09

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

I don't see why you need a library, just inherit from std::iterator and do it 
by yourself.
I will stick with 0.3 for the moment and change to another library in the 
future, because i do not like the new API, the boost dependency in this 3rd 
party library and the recent code bloat (node/*).

Original comment by km808...@gmail.com on 1 Jun 2013 at 10:06

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Sounds good to me.

By the way: Boost.Iterator does a significant amount of dirty work (see 
iterator_facade, e.g.). Also, on my system, the 0.5.1 binary is 16% larger than 
the 0.3.0 binary, which doesn't strike me as a significant amount of code 
bloat, given the more powerful API.

Original comment by jbe...@gmail.com on 3 Jun 2013 at 2:00

  • Changed state: WontFix
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter