Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

winstone sort the filter-mapping #18

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 2 comments
Closed

winstone sort the filter-mapping #18

GoogleCodeExporter opened this issue Mar 14, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

In source file: `WebAppConfiguration.java`

Has these code: 
{{{
                if (filterPatternsRequest.length > 0) {
                        Arrays.sort(filterPatternsRequest, filterPatternsRequest[0]);
                }
                if (filterPatternsForward.length > 0) {
                        Arrays.sort(filterPatternsForward, filterPatternsForward[0]);
                }
                if (filterPatternsInclude.length > 0) {
                        Arrays.sort(filterPatternsInclude, filterPatternsInclude[0]);
                }
                if (filterPatternsError.length > 0) {
                        Arrays.sort(filterPatternsError, filterPatternsError[0]);
                }
}}}

But in file `web-app_2_5.xsd`:
Section `<xsd:complexType name="filter-mappingType">` has these words:
{{{
The order in
which filters are invoked is the order in which
filter-mapping declarations that match a request URI for a
servlet appear in the list of filter-mapping elements.
}}}

So I think winstone should not sort filter-mapping,for this reason I maintain a 
branch version of winstone, my solution is remove these sort codes.

Original issue reported on code.google.com by jht5...@gmail.com on 8 Oct 2013 at 9:51

@GoogleCodeExporter
Copy link
Author

Your right
I will remove sort call

Original comment by jguibert@gmail.com on 8 Oct 2013 at 9:53

@GoogleCodeExporter
Copy link
Author

Will be on 1.0.6

Original comment by jguibert@gmail.com on 18 Oct 2013 at 10:16

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant