Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: tabGroup.tabView is null #406

Closed
jaapz opened this issue Feb 1, 2016 · 6 comments
Closed

TypeError: tabGroup.tabView is null #406

jaapz opened this issue Feb 1, 2016 · 6 comments

Comments

@jaapz
Copy link

jaapz commented Feb 1, 2016

Whenever I open a new tab using vimperator (:tabopen), after the page is opened, vimperator gives me the error in the title.

I run Firefox 45.0b1.

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2016

This is because tabgroups are being removed. See https://support.mozilla.org/en-US/kb/tab-groups-removal
We probably should prep for that. In the meantime, if you install @Quicksaver's tabgroup plugin, it'll keep it working and keep tab groups around as well!

@Quicksaver
Copy link
Contributor

FWIW I was going through all instances of tabGroup.tabView thinking an easy fix would be to null-check them all. But quite a lot of other things depend on it, and I'm not familiar with a lot of them. I'm sorry I can't write a follow-up to my previous tabview patch, but I don't feel I'm the most adequate person for that. :(

@gkatsev
Copy link
Member

gkatsev commented Feb 2, 2016

@Quicksaver you're probably just a bit less familiar with the codebase than I am and you're definitely more familiar with firefox plugin internals than I am so I don't think you're doing a bad job :P
Appreciate any help you can provide.

@Quicksaver
Copy link
Contributor

thinking an easy fix would be to null-check them all. But quite a lot of other things depend on it

Took another look, I definitely misinterpreted a lot of it the first time. Anyway, PR #414. :)

@jaapz
Copy link
Author

jaapz commented Feb 5, 2016

Thanks, I installed that tabgroup plugin and at least now the annoying message is gone again :)

@gkatsev
Copy link
Member

gkatsev commented Feb 13, 2016

Should be fixed now as part of #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants