Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'delbmarks' honour silent mode (issue #5) #18

Merged
merged 1 commit into from Jul 31, 2014

Conversation

zklinger
Copy link
Contributor

No description provided.

@gkatsev
Copy link
Member

gkatsev commented Jul 31, 2014

LGTM. Thanks.

@maxauthority Is this a PR that can be merged in without someone else looking over?

@maxauthority
Copy link
Member

@gkatsev: Patch is written in a good way, it even has a NEWS entry (which
is great!) and certainly makes sense and actually a bug fix.

So yes, sure, just pull it.

@zoltan: Thanks for the quick patch! I think there is a also an associated
bug report. If so, please also close it on GitHub.

Martin

On Thu, Jul 31, 2014 at 6:09 AM, Gary Katsevman notifications@github.com
wrote:

LGTM. Thanks.

@maxauthority https://github.com/maxauthority Is this a PR that can be
merged in without someone else looking over?


Reply to this email directly or view it on GitHub
#18 (comment)
.

gkatsev added a commit that referenced this pull request Jul 31, 2014
Make 'delbmarks' honour silent mode (issue #5)
@gkatsev gkatsev merged commit 960355e into vimperator:master Jul 31, 2014
@gkatsev
Copy link
Member

gkatsev commented Jul 31, 2014

Btw, if the description or commit message contains something like closes #5 or fixes #5 it will close the associated issue when the PR gets merged in.

@zoltan
Copy link

zoltan commented Jul 31, 2014

Remove me please.
On Jul 31, 2014 9:38 PM, "Gary Katsevman" notifications@github.com wrote:

Btw, if the description or commit message contains something like closes
#5 or fixes #5 it will close the associated issue when the PR gets merged
in.


Reply to this email directly or view it on GitHub
#18 (comment)
.

@maxauthority
Copy link
Member

@zoltan: sorry for including you, didn't know github sends mail for @ people, and I just wanted to reply to the "other" zoltan (klinger). Anyway, this bug is closed so after this message, there shouldn't be any new messages, and I don't see how I could remove you from this issue now. Please just select "unwatch" from the github's issue and you should be fine in future.

Sorry for the inconvenience.

@zklinger zklinger deleted the issue_5 branch August 11, 2014 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants