Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple functions in the same clause are not resolved correctly #120

Closed
GoogleCodeExporter opened this issue Jul 5, 2015 · 6 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Say, one has a rule:

<rule>
    <from>^/test/(.+)\.html$</from>
    <to type="redirect">/test/${upper:$1}/${upper:$1}.html</to>
</rule>

so they expect request /test/test.html to be redirected to 
/test/TEST/TEST.html. In 4.0.3 it is redirected to
test/TEST%7D/$%7BUPPER:TEST.html

Note, that this was working in 3.2.0 and got broken sometime afterwards.
Thanks.

Original issue reported on code.google.com by nkolesni...@ebi.ac.uk on 17 Sep 2012 at 12:56

@GoogleCodeExporter
Copy link
Author

I also faces this problem. So I can't use 4.0.4 . 
I hope this will be solved soon.

Original comment by kazuro.f...@gmail.com on 19 Jun 2013 at 6:18

@GoogleCodeExporter
Copy link
Author

I wrote patch to clear this issue.
This patch will support the cases below.

<to type="redirect">/test/${upper:$1}/${upper:$1}.html</to>

<to>a${upper:AbCd  ${lower:fOObAR}  1234  } b</to>


Those are the case 'two or more function continue in one <to>' and 'many 
function nest in one <to>'.
Of course, this accepts backreferences and variables.

I hope this patch will be marged next release.

Best Regards,
Fukuhara

Original comment by kazuro.f...@gmail.com on 18 Sep 2013 at 10:40

Attachments:

@GoogleCodeExporter
Copy link
Author

Sorry , I found problem. I'll delete the patch for now.

Original comment by kazuro.f...@gmail.com on 19 Sep 2013 at 5:52

@GoogleCodeExporter
Copy link
Author

I fixed the patch. Please refer this.

Best Regards,
Fukuhara

Original comment by kazuro.f...@gmail.com on 20 Sep 2013 at 2:05

Attachments:

@GoogleCodeExporter
Copy link
Author

Hi all

I publish private build of UrlRewriteFilter with this patch.
Please take a look if you are annoyed by this issue.

http://www7b.biglobe.ne.jp/~archer/urlrewritefilter/issue120.en.html

Best Regards,
Fukuhara

Original comment by kazuro.f...@gmail.com on 28 Oct 2013 at 4:02

@paultuckey
Copy link
Owner

Stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants