My favorites | Sign in
Project Home Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 8: Code Review
1 person starred this issue and may be notified of changes. Back to list
Status:  Done
Owner:  GreenArr...@gmail.com
Closed:  Sep 2012


 
Project Member Reported by dail8859@gmail.com, Sep 11, 2012
Requesting review of:
r134

Description of functionality changes:
Used the glob module to gather the list of utf files from the fields directory. I'm assuming the original code was just loading all utf files in the first level directory, not recursively. (The glob module is also not recursive.)

Sep 11, 2012
Project Member #1 dail8859@gmail.com
Also, its a good excuse to test out requesting a code review :P
Sep 11, 2012
Project Member #2 GreenArr...@gmail.com
Interestingly enough, the OpenFileDialog class in Menu.py is fully recursive, and can be set to only pay attention to a specific file type. (Such as .utf)
Sep 12, 2012
Project Member #3 GreenArr...@gmail.com
I should also note that I want to make the functionality in the near future to have a specific version of the OpenFileDialog class that will actually find all the field files in a directory and be able to display basic information about them as they are high-lighted (This would be the type of information found within the FieldDescriptor class that is pickled at the top of the file). For now I think using the glob module is a very workable solution though.
Status: Done

Powered by Google Project Hosting