Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Use bytearray buffer in StreamReader #124

Closed
GoogleCodeExporter opened this issue Apr 10, 2015 · 10 comments
Closed

Use bytearray buffer in StreamReader #124

GoogleCodeExporter opened this issue Apr 10, 2015 · 10 comments

Comments

@GoogleCodeExporter
Copy link

Using bytearray for internal buffer, instead of collections.deque is more 
efficient, and plans to do so were also expressed in the code comments. Patch 
is attached.

Original issue reported on code.google.com by yseliva...@gmail.com on 4 Feb 2014 at 5:30

@GoogleCodeExporter
Copy link
Author

code review link: https://codereview.appspot.com/60060044

Original comment by yseliva...@gmail.com on 4 Feb 2014 at 5:31

@GoogleCodeExporter
Copy link
Author

Original comment by yseliva...@gmail.com on 4 Feb 2014 at 5:31

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks! I put some review comments on Rietveld. (It's easy to download the 
patch from Rietveld, so no need to separately attach the patch. Just use 
upload.py -i to add your new version to Rietveld.)

Original comment by gvanrossum@gmail.com on 4 Feb 2014 at 7:44

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Guido, there is a new patch on Rietveld, please take a look when you have a 
time.

Original comment by yseliva...@gmail.com on 5 Feb 2014 at 7:08

@GoogleCodeExporter
Copy link
Author

Fixed in ad6c4676f809

Original comment by yseliva...@gmail.com on 5 Feb 2014 at 10:38

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

I also see that you added StreamReader.at_eof() method, what is the use case 
for such method?

Original comment by victor.s...@gmail.com on 6 Feb 2014 at 2:48

@GoogleCodeExporter
Copy link
Author

See https://code.google.com/p/tulip/issues/detail?id=101&can=1

Original comment by yseliva...@gmail.com on 6 Feb 2014 at 2:49

@GoogleCodeExporter
Copy link
Author

Oh, reminder. When a commit fixes an issue, the commit message should mention 
the issue#. With the right syntax (I think "fix issue #NNN") it'll 
automatically include the commit in the issue.

Original comment by gvanrossum@gmail.com on 6 Feb 2014 at 3:56

@GoogleCodeExporter
Copy link
Author

NP

For some reason I thought google code does not support this feature.
What's the protocol for committing back to cpython? Should a proxy issue on 
bugs.python.org be created, or we can simply put a url to google code issue?

Original comment by yseliva...@gmail.com on 6 Feb 2014 at 4:32

@GoogleCodeExporter
Copy link
Author

I've done neither so far -- I just prefix the commit message with "asyncio:" 
and assume people will figure out to compare the change logs in cpython with 
those in the Tulip repo (which I consider upstream). Oh, and every once in a 
while I trawl the logs and add a mass NEWS item. Nothing too formal.

Original comment by gvanrossum@gmail.com on 6 Feb 2014 at 5:14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant