Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon for the feedlist and the articlelist #18

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments
Closed

Favicon for the feedlist and the articlelist #18

GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

It would be nice if the feeds favicon could be displayed in the feedlist and in 
the articlelist. 

I have subscribed one feed (http://www.heise.de/newsticker/heise-atom.xml) 
where all the articles are always empty and so I have to visit the website for 
every article.
If I could see the favicon in the articlelist I could easily skip this article 
if I don't want to open the browser for this article from this specific feed.

Original issue reported on code.google.com by schla...@gmail.com on 24 Aug 2010 at 10:01

@GoogleCodeExporter
Copy link
Author

It is possible to do this, but someone needs to do it ;)

The API-method api/?op=getConfig returns the icons_url path which has to 
appended to the url like http://server/icons_url/xx.ico (where xx is the id of 
the feed).

Original comment by nils.braden on 25 Aug 2010 at 12:17

  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

I tried to work on this feature request. I'm having a rough version at the 
moment, but I'm not happy with two things

1) downloading the icons isn't as fast as it should be. 
2) the icons are not available in good enough quality

If you look at the attached image, you can see that displaying the favicons is 
really ugly. I think this problem couldn't be solved, because the icons are to 
small (eg. 16px or height)

Would it be possible to display the feed title next to the update date in the 
article view?
This could also solve my problem. I need to know from which feed the article 
is?!

What is your opinion on this issue?

Original comment by schla...@gmail.com on 30 Aug 2010 at 6:37

Attachments:

@GoogleCodeExporter
Copy link
Author

1) downloading the icons isn't as fast as it should be. 
Shouldnt be a problem if we do it in background and display the icons as they 
come in, has to be done only once so speed does not really matter i think.

2) the icons are not available in good enough quality
That seems to go for all favicons as they are usually supposed to be displayed 
in the browsers navigation-toolbar. But since they are small we can just keep 
it that way and display all icons in 16x16px or something. The rows should get 
a fixed height with the icons centered in the icon-area then i think it doesnt 
look so bad.

Another way would be displaying the old icons for feeds and inserting the 
favicons in the row before the feed-name so we would have 
<feed-icon><favicon><feed-name> in every row. The feed-icon would define the 
height of the row and the favicon would be smaller and right next to the 
feed-icon. And in the FeedHeadlineView we could display the icon in the 
titlebar next to the name of the feed. What do you think?

"Would it be possible to display the feed title next to the update date in the 
article view?
This could also solve my problem. I need to know from which feed the article 
is?!"
Hm, versteh ich das richtig, du willst das Datum der letzten Aktualisierung da 
mit anzeigen? Wird das nicht bischen unübersichtlich? Und welches genau, das 
des letzten Abrufs des Feeds durch den Server oder das Datum wann der Feed 
zuletzt vom Handy aktualisiert wurde? Letzteres wäre bei allen Feeds der selbe 
Wert weil fast immer alle mal aktualisiert werden.
Zu welchem Feed ein Article gehört steht in ArticleItem.getFeedId(), mit der 
ID kannst du in der HashMap DataController.mFeeds suchen, Key ist jeweils die 
Feed-ID als String. Hoffe ich hab die Frage richtig verstanden :)

Greetings,
nils

Original comment by nils.braden on 4 Sep 2010 at 2:20

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by nils.braden on 7 Aug 2011 at 11:13

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant